[Bug]: the required Windows lane fails on the long-path CLI budget fixture because the fixture pins the workload path length but not its JSON-escaped cost
Los mantenedores suelen responder en 1 día
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 2/5
- Tiempo estimado
- 1-3 horas
- Aptitud para principiantes
- 84/100
Línea de trabajo
Empieza por tests/control_plane/test_cli_output_budget.py y el fixture de rutas largas que fija la raíz en 128 caracteres. Reproduce el problema con el comando pytest documentado y un espacio de nombres temporal más profundo. Se considera terminado cuando las tres pruebas de presupuesto de rutas largas producen la misma carga de trabajo medida y pasan independientemente de la profundidad del directorio temporal de Windows.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
LoopX version or commit: main dc9fdbb51
Host or runtime surface: Not host-specific (fails in the required windows-powershell lane; the defect is in the budget fixture, not in the CLI)
Area: Build, packaging, installer, or CI (required-check regression in Python Tests)
Problem
The required windows-powershell job of the Python Tests workflow is red on the current main head, and it fails on exactly three tests:
FAILED tests/control_plane/test_cli_output_budget.py::test_long_path_budget_is_independent_of_runner_temp_prefix
FAILED tests/control_plane/test_cli_output_budget.py::test_long_path_budget_uses_native_temp_without_a_drive_root_directory[False]
FAILED tests/control_plane/test_cli_output_budget.py::test_long_path_budget_uses_native_temp_without_a_drive_root_directory[True]
AssertionError: heartbeat_prompt_brief/json emitted 10522 chars; variant ceiling is 10500
merge-gate lists windows-powershell in needs, so the whole required qualification is red for that lane. Runner: job 117808033252 in run 39172287050.
The long-path budget fixtures build a fixture root whose path length is pinned to 128 characters so that the measured packet is host-independent:
parent = Path(tempfile.gettempdir() if os.name == "nt" else "/tmp").resolve()
...
while len(str(parent / prefix)) + 8 > 128:
parent = parent.parent
prefix += "p" * (128 - len(str(parent / prefix)) - 8)
with tempfile.TemporaryDirectory(prefix=prefix, dir=parent) as directory:
root = Path(directory).resolve()
assert len(str(root)) == 128
Path length is not the quantity the budget measures. The emitted heartbeat_prompt_brief JSON quotes the fixture root and the paths derived from it about twenty times, and JSON escapes every Windows separator in each quoted copy, so emitted size grows with both the length and the separator count. Varying the fixture root on this checkout gives:
emitted_chars(root) = 7782 + 20 * len(root) + 20 * separators(root)
At the pinned 128-character length this reduces to 10342 + 20 * separators, the rows below:
A 128-character root therefore measures differently on every host, depending only on how deep its temporary namespace is:
| Fixture root | separators | measured chars | verdict (ceiling 10500) |
|---|---|---|---|
D:\Temp\<128-char root> |
2 | 10382 | passes |
D:\Temp\a\b\c\pytest-1\<128-char root> |
5 | 10442 | passes |
hosted Windows runner C:\Users\<user>\AppData\Local\Temp\pytest-of-<user>\pytest-1\test_...\<128-char root> |
9 | 10522 | fails |
local deep TEMP (five nested segments) |
10 | 10542 | fails |
So the guard reports a failure for a deep temporary namespace rather than for a change in the emitted packet, and the size of the measured workload is not the one the ceilings were pinned against. #6833 (merged in dc9fdbb51) exposed this by adding long_path_budget to the Windows lane selection and by holding only the length constant; the runner's temp namespace is four segments deeper than the local one, which is exactly the observed 10522 - 10442 = 80 = 4 x 20 difference.
Impact
windows-powershellis a required lane (merge-gateneeds it): the required qualification is red onmain, and every pull request based on currentmaininherits a failing required check it did not cause.- The same three tests are part of the scheduled
Python Testsqualification, so the daily run is red for this cause as well. - The guard cannot be trusted on Windows in either direction: on a deeper namespace it fails without any packet change, and on a shallower one it measures a smaller workload than the pinned ceiling describes.
Minimal reproduction
git checkout dc9fdbb51
uv sync --extra test
# point the host temp namespace deeper than the workload, as the hosted runner does
# PowerShell: $env:TEMP = $env:TMP = "<deep-drive>/a/b/c/d/e"
TEMP=<deep-drive>/a/b/c/d/e uv run --extra test python -m pytest -q \
tests/control_plane/test_cli_output_budget.py -k long_path_budget
Observed on dc9fdbb51: the same three failures, with the emitted count 10542 instead of 10522 because the namespace is one segment deeper.
Expected behavior
The three tests qualify the same workload on every host: a fixture root that the emitted-text budget sees with a constant cost (or a comparison that accounts for the root the fixture actually created), so the verdict does not depend on the depth of the host's temporary namespace.
Actual behavior
The verdict depends on the host's temporary-namespace depth, and the required Windows lane stays red on main until the fixture holds the measured quantity constant.
- Lenguaje dominante
- Python
- Estrellas
- 6.2k
- Forks
- 596
- Merge medio
- 6 h 44 min
- PR fusionados (30 d)
- 915
Preparar el entorno
- Sin Dockerfile ni archivo de Docker Compose
- Tiene una plantilla de pull request
- Leer la guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de loopx-project/loopx
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
loopx-project/loopx#6108 ·
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 65/100
loopx-project/loopx#5688 · 2 comentarios ·
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 60/100
loopx-project/loopx#5632 · 1 comentario ·
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 65/100
loopx-project/loopx#5443 · 1 comentario ·
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
loopx-project/loopx#5026 ·
Los mantenedores suelen responder en 1 día
Todos los issues de loopx-project/loopx
Issues similares
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 76/100
-
[Device Support Request] HOBEIAN ZG-204ZL (Tuya PIR motion sensor with illuminance)Posiblemente ocupada @lenucksi la tomó hoy. Abierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
zigpy/zha-device-handlers#5493 ·
Los mantenedores suelen responder en 3 días
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
drevendev/BeautifulRepo#42 ·
Los mantenedores suelen responder en 1 día
-
enhancement good first issue
Dificultad 2/5 1-3 horas Aptitud para principiantes 84/100
writerslogic/holographic-memory#93 ·
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 66/100
antoine-tena/kiln#47 ·
Los mantenedores suelen responder en 1 día