[bug] `AudioPublishOptions.red` is inverted: the default `red: true` sends `disableRed: true`, disabling RED for every audio publish

Cerrado
  • ¿Algo no está bien?
#1,271 0 comentarios 0 reacciones 1 asignado Ver en GitHub

Los mantenedores suelen responder en 2 días

@hiroshihorie ya está trabajando en esto.

Desde el 30/10/2026.

  • #1272 de @hiroshihorie — fusionado

Evaluación

Este issue todavía no se ha evaluado.

Descripción

Describe the bug

AudioPublishOptions.red (default true, documented as "red (Redundant Audio Data)") is passed into AddTrackRequest.disableRed without negation, so every audio publish with default options disables RED:

// lib/src/participant/local.dart
disableDtx: !publishOptions.dtx,                                           // negated — correct
disableRed: room.e2eeManager != null ? true : publishOptions.red ?? true,  // not negated

The JS SDK negates it (src/room/participant/LocalParticipant.ts):

disableRed: this.isE2EEEnabled || !(opts.red ?? true),

Evidence:

  • Introduced by 6323ff7 (#453, 2024-01-23); the inverted line is that commit's only change to lib/src/participant/local.dart. Before it the field was never set, and the protobuf default (false) left RED enabled — so RED has been off for Flutter publishers since v2.0.0.
  • The line is identical in 2.3.0–2.13.0, the v2.13.2 tag, and current main (checked 2026-10-30).
  • The docs recommend RED enabled and document red: false as the opt-out: "LiveKit recommends enabling this feature because audio glitches are so distracting that the tradeoff is almost always worth it" — https://docs.livekit.io/transport/media/advanced/
  • The E2EE force-disable branch matches the JS SDK; only the non-E2EE branch is inverted.

To Reproduce

Publish a microphone track with default options: the AddTrackRequest carries disableRed: true. Publish with red: false: it carries disableRed: false — inverted.

Expected behavior

red: true (the default) → disableRed: false. Proposed fix:

disableRed: room.e2eeManager != null || !(publishOptions.red ?? true),

Release-note caveat: apps that noticed and set red: false to force RED on will flip behavior when this is fixed.

Platform information

  • Flutter version: 3.47.6
  • Plugin version: 2.13.0
  • Flutter target OS: Web — but the field is set in shared Dart, so all platforms are affected
Lenguaje dominante
Dart
Estrellas
421
Forks
260
Merge medio
2 d 10 h
PR fusionados (30 d)
22

Preparar el entorno

Este proyecto no incluye contenedor de desarrollo, Dockerfile ni guía de contribución, así que la configuración corre por tu cuenta: empieza por su README y consulta nuestra guía para la primera contribución para los pasos generales.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de livekit/client-sdk-flutter

Todos los issues de livekit/client-sdk-flutter

Issues similares

Más issues de Dart

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.