Font Awesome SVGs eat clicks meant for their parent buttons (I could be misjudging the issue)

Abierto
#1,625 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
2/5
Tiempo estimado
1-3 horas
Aptitud para principiantes
58/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
css, php

Línea de trabajo

Start by locating the bottom right buttons and their Font Awesome SVG styles, then check how clicks on the SVG affect the parent button. Compare the behavior with the reported .svg-inline--fa { pointer-events: none; } suggestion and verify clicks on both the icon and the button area. Done means the icon and surrounding button area trigger the same action.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

To start, I've encountered this issue on multiple versions of Heimdall. I run Heimdall in a Docker container on my NAS & it's managed via Dockhand. I believe that the issue is as the title says: the buttons in the bottom right corner seem to only work when the button is pressed outside of the icon on the button. I'm using Vivaldi & I went to Dev Tools > Inspect to see what was happening. I entered document.addEventListener('click', e => console.log('clicked:', e.target), true); in Console to do just that.

Outcome:

document.addEventListener('click', e => console.log('clicked:', e.target), true);
undefined
VM667:1 clicked: <div id=​"sortable" class=​"folders">​…​​flex
VM667:1 clicked: <a id=​"config-button" class=​"config" href>​…​​flex
VM667:1 clicked: <svg class=​"svg-inline--fa fa-exchange fa-w-16" aria-hidden=​"true" data-prefix=​"fas" data-icon=​"exchange" role=​"img" xmlns=​"http:​/​/​www.w3.org/​2000/​svg" viewBox=​"0 0 512 512" data-fa-i2svg>​…​​
VM667:1 clicked: <a id=​"config-button" class=​"config" href>​…​​flex

My apologies if I'm over explaining (especially, if it's a non-issue). "Sortable" was me clicking outside of the button for context. "Config-button" was me clicking inside the bounds of the button but not on the icon on the button. Next, was me clicking on the actual icon in the bounds of the button & getting a different result. Then, I repeated the 2nd click.

After to doing research, the supposed solution was this:
.svg-inline--fa { pointer-events: none; }

My YAML:
services:
heimdall:
image: linuxserver/heimdall:latest
container_name: heimdall
environment:
- PUID=1000
- PGID=1000
- TZ=America/Los_Angeles
- ALLOW_INTERNAL_REQUESTS=false #optional
volumes:
- /vol1/@team/Household/Heimdall/config:/config
ports:
- 9080:80
- 9443:443
restart: unless-stopped
healthcheck:
test: ["CMD-SHELL", "wget --no-verbose --tries=1 --spider http://localhost/ || exit 1"]
interval: 1m
timeout: 10s
retries: 3
start_period: 30s

Heimdall version: v2.8.4-ls372
Docker Compose Version: 5.3.1

Not sure if I'm missing anything. I will gladly give more info, if needed/wanted. Thanks in advance for you time.

Lenguaje dominante
PHP
Estrellas
9.4k
Forks
626
Merge medio
13 min
PR fusionados (30 d)
3

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de linuxserver/Heimdall

Todos los issues de linuxserver/Heimdall

Issues similares

Más issues de PHP

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.