Define policy for tests
@folkyatina ya está trabajando en esto.
Desde el 16/6/2022.
Evaluación
Este issue todavía no se ha evaluado.
Descripción
Simple summary
We should discriminate omnibus votes into two categories: sensitive protocol upgrades & others
- The First category requires unit, regression, snapshot, and integration test suites.
- For the second category, it's possible to skip the snapshot tests for the sake of reducing process overheads
Motivation
We have adopted GitHub CI process recently for the repo. While it is always good to achieve a bright green mark for every pushed head by running as many tests as possible, it also requires additional effort to maintain the repo consistency.
Snapshot tests usually represent the following invariant: 'all states should be left as is except only X', thus you have to define 'X' properly for each voting script. If you have multiple voting scripts then complexity rises drastically.
At the same time, other types of tests usually check only the new state and have no assumptions for the diff items over all state slots and their values.
Proposal
Option 1. Mark protocol upgrade votings differently (naive and dirty)
For e.g., we may use upvote_xx_xx_xx.py filename pattern which should be followed by the tests runner as a flag to run additional tests.
Option 2. Bake a framework for the snapshot tests
Following the approach, one will need to import the desired snapshot tests and define the expected state diffs for them.
Decision (TBA)
Personally, I believe that option 2 should be implemented.
Other opinions and options are highly appreciated here.
FYI: @folkyatina, @ujenjt
- Lenguaje dominante
- Python
- Estrellas
- 9
- Forks
- 3
- Merge medio
- 5 d 53 min
- PR fusionados (30 d)
- 4
Preparar el entorno
- Incluye un Dockerfile o un archivo de Docker Compose
- Sin plantilla de pull request
- Sin guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de lidofinance/scripts
-
Dificultad 3/5 1-2 días Aptitud para principiantes 55/100
lidofinance/scripts#265 ·
-
Dificultad 5/5 Más de una semana Aptitud para principiantes 25/100
lidofinance/scripts#96 ·
Todos los issues de lidofinance/scripts
Issues similares
-
Link Checker ReportAbiertoautomated issue linkchecker report
Dificultad 2/5 1-3 horas Aptitud para principiantes 66/100
QuantEcon/lecture-python.myst#1098 ·
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 82/100
-
[Bug]: Processing errors missing from Docker logs due to incorrect console-handler detectionAbiertobug
Dificultad 2/5 1-3 horas Aptitud para principiantes 82/100
podly-pure-podcasts/podly_pure_podcasts#279 ·
Los mantenedores suelen responder en 1 día
-
New template proposal: ljpAbiertotemplate-proposal
Dificultad 1/5 Menos de una hora Aptitud para principiantes 78/100
-
Dificultad 1/5 Menos de una hora Aptitud para principiantes 82/100
OpenShot/openshot-qt#6230 ·
Los mantenedores suelen responder en 1 día