RTree: wait for an official Lance release containing the non-finite bounds reload fix

Abierto
#153 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
5/5
Tiempo estimado
Más de una semana
Aptitud para principiantes
15/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
c, cpp, rust
Área
backend, database

Línea de trabajo

Start by checking official Lance releases and verifying that the release includes the fix from PR #10747. Then assess its compatibility with the pinned v14.0.2 core; the issue names the regression in tests/c_api_test.rs and gives the command to reproduce it. Done means the normal migration and binding acceptance checks pass on the release candidate before PR #149 resumes.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

PR #149 adds C/C++ access to native RTree index creation. The maintainer decision on 2026-11-11 is to keep the PR open and held, retain the current v14.0.2 core pin, and wait for an official upstream release containing the fix. Fork or backport publication is excluded by this decision.

PR #149 remains on hold while the official-release candidate is assessed and dependency migration and acceptance are resolved. The current dependency pin and preserved binding candidate remain unchanged; release discovery alone does not resume the PR. This issue tracks the concrete candidate and the acceptance still needed.

The selected core is Lance v14.0.2 at 40f15ed1b71b66950961b175829fdf17a763f108. An RTree with non-finite stored bounds can lose valid finite spatial matches after reload. Non-finite bounding-box coordinates serialize as JSON null. The metadata then fails JSON decoding and falls back to an empty box in rust/lance-index/src/scalar/rtree.rs. Search then skips the tree.

The original failure was confirmed through both C and direct native Rust after index creation and reopen. The indexed plans contained ScalarIndexQuery, while the flat scans returned the expected finite match.

ffi_indexed=[], ffi_flat=[1], native_indexed=[], native_flat=[1]

The regression is preserved at 4ca7baf. Run it against that revision with Rust 1.94.0.

cargo +1.94.0 test --locked --test c_api_test test_rtree_reloaded_nonfinite_bounds_keep_finite_matches -- --exact --nocapture --test-threads=1

The upstream fix is Lance PR #10747, merged as 20f5ccdf5cbd4f8ae8767d8314b589a0c3e777f0. It is absent from the selected pin. A private one-file v14 backport passed the original C/native regression with all four results [1], the new native regression and all 11 native RTree module tests on NieR. Targeted native Clippy was blocked by pre-existing warnings outside the changed file. The backport was kept private and the product dependency pin remains unchanged.

  • Identify an official Lance release containing the upstream fix and verify its source ancestry: v15.0.0-beta.19 (official prerelease; candidate only).
  • Assess and accept its dependency/API/compatibility delta from the selected v14.0.2 core.
  • Update the core through the normal migration workflow and integrate the preserved regression into #149.
  • Rerun the original C/native indexed-versus-flat failure path, RTree lifecycle/query coverage, full binding checks and real C11/C++17 consumers on the actual candidate.
  • Resume #149 only after the new core and binding candidate pass acceptance.

PR #149 head 5f48438afac95b7a7effc19417b480c31bb67389 already passed its finite-data tests and hosted checks. Those results do not cover this confirmed reload failure. The previous red evidence is preserved on NieR at /home/xuanwo/Code/executions/lc149-rtree-nonfinite-4ca7baf/, and the private repair experiment at /home/xuanwo/Code/executions/lc149-rtree-core14-nier-20261111T035101Z.

Official prerelease candidate assessed on 2026-11-13

Lance v15.0.0-beta.19 was officially published at 2026-11-11T22:35:15Z with prerelease=true. The annotated tag resolves to 98f84091db531775ab03fa7edb3d34c86937fbf5; upstream fix 20f5ccdf5cbd4f8ae8767d8314b589a0c3e777f0 is an ancestor. The current RTree source (blob b11dd3c03220441d4cc12934a66261b68bfd599c) retains the full-plane fallback and test_non_finite_bounds_are_not_treated_as_empty. Both the release metadata and immutable Git objects were verified; this is source evidence, not an accepted binding regression run.

This candidate does not satisfy the current binding toolchain contract: its workspace manifest requires Rust 1.95.0, while lance-c currently declares and validates 1.94.0. The release also introduces breaking action-based Transaction V2 (#7954); the binding exposes native transaction protobuf transport, so compatibility must be assessed explicitly. The RTree implementation has moved from lance-index to lance-geo. No toolchain change, dependency-pin migration, format acceptance or hold change is authorized by release ancestry alone.

The latest stable release is still v14.0.2, but the recorded decision was to await an official release; this assessment does not add a stable-only restriction. A compatible official candidate or an explicit decision covering the new toolchain/migration contract is needed before dependency adoption. Until then, #149 stays held under its current pin. There is no evidence here that the separate raw Blob reader defect #167 / lance-format/lance#10944 is fixed.

Parent capability tracking remains #110 and #99. Their other independent work continues.

Lenguaje dominante
Rust
Estrellas
8
Forks
17
Merge medio
1 h 14 min
PR fusionados (30 d)
89

Preparar el entorno

Este proyecto no incluye contenedor de desarrollo, Dockerfile ni guía de contribución, así que la configuración corre por tu cuenta: empieza por su README y consulta nuestra guía para la primera contribución para los pasos generales.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de lance-format/lance-c

Todos los issues de lance-format/lance-c

Issues similares

Más issues de Rust

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.