Re-running an old merge's publish can move canary back

Abierto
#134 1 comentario 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
72/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
github-actions, typescript
Área
ci-cd, release

Línea de trabajo

Start by reading .github/workflows/publish.yml, especially the build and registry jobs, and trace how a canary publish is triggered when failed jobs are rerun. Reproduce the M1/M2 sequence described in the issue and check where the “main has moved past this commit” guard runs. Done when rerunning an older failed registry job cannot move the canary tag back.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

The guard that refuses to move canary back to an older merge runs only in the build job of publish.yml. "Re-run failed jobs" on an older merge's run re-runs only the failed npmjs job, so the guard does not run again.

How it fails: merge M1's npmjs job fails, merge M2 then publishes its canary, and someone re-runs M1's failed jobs. M1's version is not on npmjs yet, so npm publish --tag canary points canary back at M1.

Repeat the "main has moved past this commit" check inside the registry jobs (or right before npm publish when the tag is canary). Found in the ready-gate review of #132; not introduced by it.

Lenguaje dominante
TypeScript
Estrellas
2
Forks
0
Merge medio
1 d 1 h
PR fusionados (30 d)
35

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de lablup/ui-common

Todos los issues de lablup/ui-common

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.