notifications: regression/ recipients with scope

Abierto
  • ¿Algo no está bien?
#2,114 5 comentarios 0 reacciones 1 asignado Ver en GitHub

Los mantenedores suelen responder en 2 días

@felipebergamin ya está trabajando en esto.

Desde el 22/10/2026.

  • #8 de @felipebergamin — cerrado sin fusionar
  • #2193 de @felipebergamin — abierto

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
55/100
Tipo de issue
Nueva funcionalidad
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
python
Área
backend, ci-cd, documentation, testing

Línea de trabajo

Empieza inspeccionando los archivos de suscripción existentes en backend/data/notifications/subscriptions/ y los modelos de Pydantic utilizados por typeModels. Después, sigue el parser actual y las pruebas de validación de CI antes de añadir backend/data/notifications/metrics/ y actualizar docs/notifications.md. Se considera terminado cuando todos los archivos existentes se cargan, los archivos no válidos hacen fallar la CI con errores de archivo y de campo, y se prueba la equivalencia de los destinatarios.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

notifications

Problem

[REGRESSION] Cc is the default_recipients of the tree file whose url matches the issue (_get_default_tree_recipients in helpers/common.py). Branch and architecture are ignored. The same list is also Cc on the daily [STATUS] summary.

Change

[REGRESSION] Cc moves to backend/data/notifications/regression/. default_recipients stays in subscriptions/ and stays the [STATUS] Cc. Do not remove or empty it. Automatic sending stays maestro build issues. Regzbot Cc, REGZBOT_TREES, and KERNELCI_REPLYTO stay in helpers/common.py.

The first commit copies recipients once: for every subscriptions/*.yaml that is not *_hardware.yaml, including files with no reports key, write regression/<tree>.yaml with one entry whose recipients are that file's default_recipients, copied unchanged (display name included). Skip files with an empty list. This is committed data. Do not add a command or any runtime read of subscriptions/ to fill regression/. After the commit, regression/ is edited by hand.

# regression/default.yaml
# Replaces KERNELCI_RESULTS on the regression path only. The [STATUS] cron
# keeps --add-mailing-lists and the constants in common.py.
to: [email protected]

# regression/stable.yaml — top-level key must be a tree key in subscriptions/
stable:
  - recipients: [[email protected]]          # no scope keys: every build issue on this tree's URL
  - branch: [linux-6.12.y, linux-6.6.y]
    architecture: [arm64]
    recipients: [[email protected]]
Key Values Matched against
recipients RFC 5322 strings, ≥1, stored and sent unchanged —
issues build only issue kind
branch str or list git_repository_branch already returned by kcidb_issue_details (first incident, the branch printed in the mail)
architecture, config_name, compiler str or list any row already returned by kcidb_build_incidents

No new query. An entry matches when every key it sets is satisfied. Cc is the union of matching entries, deduplicated. An entry with only recipients matches every build issue on that tree's URL. platform, origin, hardware-keyed files, and issues other than build are validation errors.

--to, --cc, --add-mailing-lists, and --ignore-recipients keep today's semantics; --ignore-recipients skips regression/. generate_test_report does not use scoped entries: its Cc is the union of entries that have no scope keys, matched by URL, which is today's list.

Implementation

  1. typeModels/notificationRecipients.py: RecipientEntry (pydantic, extra="forbid", str-or-list normalized to list), RecipientDefault (to only). load_recipient_files(directory, *, allowed_keys, allowed_issues) -> dict[str, list[RecipientEntry]]. Each tree key must exist in subscriptions/; the loader records that tree's url. Two subscription files with the same url is a validation error. Errors carry file, entry index, and key.
  2. Commit the copied regression/<tree>.yaml files.
  3. helpers/common.py: replace _get_default_tree_recipients with resolve_regression_recipients(issue, build_incidents) -> list[str], reading only regression/. send_email_report stops calling the lookup; generate_issue_report passes recipients=. generate_test_report passes the unscoped entries for that URL.
  4. On the regression path, the list address used when --add-mailing-lists is set comes from regression/default.yaml instead of KERNELCI_RESULTS. Reply-To and regzbot behavior are unchanged.
  5. Header line in issue_build.txt.j2 and issue_boot.txt.j2: Cc from: regression/<tree>.yaml. No header change in test_report.txt.j2.
  6. docs/notifications.md: regression Cc is edited in regression/; default_recipients is the [STATUS] list only.

Tests

Loader fixtures: valid, unknown tree, duplicate URL, unknown key, platform, origin, issues: [boot]. Resolver fixtures: branch, architecture, no match, dedup, scope-less entry matches all, test-report path ignores scoped entries. One test loads the real regression/ directory so an invalid committed file fails pytest -m unit.

Acceptance

  • After the copy commit, every tree's [REGRESSION] Cc equals its old default_recipients, and [STATUS] Cc is unchanged
  • A scoped entry is Cc'd only when the branch and a build incident match
  • An invalid file fails CI with file, entry, and key
  • The build and boot bodies name the regression/ file

#2159 is rebased onto this scope: keep the loader and validation work, drop the per-recipient issues list, the rewrite of the subscription files, and the metrics directory.

Closes #1080.

Lenguaje dominante
Python
Estrellas
10
Forks
32
Merge medio
3 d 19 h
PR fusionados (30 d)
33

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de kernelci/dashboard

Todos los issues de kernelci/dashboard

Issues similares

Más issues de Python

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.