EgressPolicy: option to add a credential header when the request has none

Abierto
  • ¿Algo no está bien?
#3,306 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
55/100
Tipo de issue
Nueva funcionalidad
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
go, kubernetes, yaml
Área
backend-api-design, security

Línea de trabajo

Start with substrate/cmd/atenet/internal/router/egress/credentials.go and docs/architecture/egress-policies.md, which the issue names. Trace how applyEffects handles a missing credential header and how destinations[].authentication is represented and validated; then check the egress policy tests. Done means an opt-in inject: Always adds the configured header when absent, replaces it when present, and leaves the default behavior unchanged.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

What we're trying to do

We run Kagent agents that work on a git repository. An agent's EgressPolicy
opens https://github.com with authentication that injects a GitHub token as
Authorization: Basic …, so the agent can git clone and git push without
the token ever entering the sandbox.

The problem

The egress gateway only replaces a credential header the request already
carries. It never adds a missing one (applyEffects in
substrate/cmd/atenet/internal/router/egress/credentials.go, and
docs/architecture/egress-policies.md). Plain git, npm, pip or curl send no
Authorization header, so the credential is never used.

Every client then has to be configured to send a placeholder:

  • A static placeholder (for example git's http.<url>.extraHeader) is sent
    on every request. Where the agent has no credential, the placeholder goes
    out unchanged. GitHub answers a bad credential with 401 even on public
    repositories, so anonymous clones break.
  • A placeholder that is sent only after a 401 (a git credential helper) works
    for git, but it's a shell snippet per client, and other clients have no
    equivalent.
  • Neither can be set per agent, because Kagent sets env per Harness, not per
    Agent or AgentTemplate.

Proposal

An opt-in setting on destinations[].authentication that makes the gateway
add the header when the request doesn't carry one, and still replace it when
it does. For example:

spec:
  destinations:
    - origin: https://github.com
      authentication:
        header: Authorization
        prefix: "Basic "
        secretKeyRef: {name: repo-token, key: git}
        inject: Always   # default: IfPresent (today's behavior)
  • The default stays as it is, so nothing changes for existing policies.
  • The gateway already writes the header with OVERWRITE_IF_EXISTS_OR_ADD, so
    this changes only the check that skips requests without the header.
  • authentication already requires an exact origin, so Always only covers
    hosts an administrator named explicitly.

With this, any client in the sandbox authenticates to an allowed origin
without configuration or placeholders. The credential still never enters the
sandbox.

Alternatives considered

  • Per-Agent env on AgentTemplate, which would let each agent get its own
    placeholder configuration. It's still per client, and it was deferred
    before.
  • Harness per credential set: it multiplies Harnesses and sandboxes for what
    is policy, not runtime.

Happy to contribute a PR if the direction is acceptable.

Lenguaje dominante
Go
Estrellas
4.2k
Forks
890
Merge medio
1 d 10 h
PR fusionados (30 d)
171

Preparar el entorno

Abrir en Codespaces

Inicia el contenedor de desarrollo del proyecto en tu navegador, con tu propia cuenta de GitHub.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de kagent-dev/kagent

Todos los issues de kagent-dev/kagent

Issues similares

Más issues de Go

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.