[Bug]: version latest with download-repository can install a stale CLI
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 5/5
- Tiempo estimado
- Más de una semana
- Aptitud para principiantes
- 35/100
- Tipo de issue
- Error
- Claridad
- Bastante claro
- Estado de actividad
- Activo
- Stack tecnológico
- github-actions, typescript
Línea de trabajo
Empieza en getCliUrl, donde latest se asigna a [RELEASE], y sigue la ruta del repositorio de descargas y sus pruebas existentes. Revisa cómo se gestionan los listados de repositorios, el filtrado por OS/arquitectura, la ordenación semver, la autenticación y el comportamiento de fallback. El trabajo estará terminado cuando exista una resolución opt-in y compatible con versiones anteriores de latest a una versión inmutable, sin nuevos fallos ni llamadas de red obligatorias, con cobertura para el contenido [RELEASE] en caché y los modos de repositorio descritos.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Describe the bug
version: latest combined with download-repository can keep installing an old JFrog CLI indefinitely.
latest is translated to [RELEASE], and [RELEASE] is part of the artifact path, so the action requests:
{artifactory}/{download-repository}/v2/[RELEASE]/jfrog-cli-<os-arch>/jfrog
A remote repository caches artifacts by the path it resolved. For a concrete version such as v2/2.123.0/... that is exactly what you want: the artifact is immutable, so caching it is a pure win. For a moving tag it breaks, and the Artifactory cache settings do not rescue it:
- Store Artifacts Locally is enabled by default, so the resolved binary is cached under the literal
v2/[RELEASE]/...path. - Metadata Retrieval Cache Period does not apply. Per the remote repository docs, that period is "relevant for artifacts that expire after a period of time", while "most downloaded artifacts do not change and this setting does not affect them". A CLI binary is one of those artifacts that do not change.
- Zapping the cache does not help either: per the same docs, "immutable binaries are not invalidated".
- Unused Artifacts Cleanup Period is empty by default, which means artifacts are "stored indefinitely" — and a binary a CI pipeline downloads on every run is never "unused" anyway.
So the first version resolved through that path can be served as latest forever, with no error and no obvious way for the user to notice.
Current behavior
- uses: jfrog/setup-jfrog-cli@v4
with:
version: latest
download-repository: jfrog-cli-remote
Requests keep succeeding and the download URL looks correct, so nothing signals a problem.
Observed: a runner installed jf 2.91.0 while 2.123.0 was already published, and CI failed a minimum-version check with an error that gives no hint about the cached tag. Requesting the same latest directly from https://releases.jfrog.io/artifactory/jfrog-cli returned 2.123.0.
Reproduction steps
- Create a generic remote repository proxying
https://releases.jfrog.io/artifactory/jfrog-cli, leaving Store Artifacts Locally enabled and Unused Artifacts Cleanup Period empty (both defaults). - Run setup-jfrog-cli with
version: latestanddownload-repositoryset to that repository, sov2/[RELEASE]/...is cached. - Wait for a newer CLI release and run the same workflow again.
- The cached version is installed again, not the newer release.
Expected behavior and compatibility requirements
latest should not depend on a cached moving tag. Because this action runs in a very large number of workflows, the fix must not introduce new failures.
- Preserve existing successful workflows by default. Do not newly reject or fail
latest+download-repository. - Never request a moving tag through a repository that caches artifacts. Resolve a concrete
X.Y.Zand downloadv2/X.Y.Z/..., so every version is cached under its own immutable path. - Keep all downloads inside
download-repositorywhen it is set. Never fall back to the public internet, because the runner may have no Internet access. - Do not assume every
download-repositoryis a connected proxy. It may haveStore Artifacts Locallydisabled (direct streaming, no cache), be markedOffline, or be a repository whose content administrators manage themselves. - Prefer a backward-compatible, opt-in rollout until the new resolution is proven against connected proxies, cache-only repositories, and self-managed repositories.
- When selecting a version, filter for the current OS/architecture, sort with semver rather than lexically (
2.91.0sorts above2.123.0as a string), and keep the current download path if resolution yields nothing. Note that folder listing through a remote reflects repository content, and on generic remotes it depends onList Remote Folder Items, which is API-only — so it is not automatically "newest on origin". - Tests must prove no new throw,
core.setFailed, non-zero exit, authentication call, or additional required network call on the existing path, and must cover a repository that already has an old version cached underv2/[RELEASE].
Until then the safe guidance is a concrete version: X.Y.Z whenever download-repository is used.
Setup JFrog CLI version
v4.10.1 / current master (getCliUrl maps latest to [RELEASE])
JFrog CLI version
latest
Workflow operating system type and version
Not OS specific — any runner using latest through a caching repository can be served the cached version.
JFrog Artifactory version (if relevant)
Any remote repository proxying releases.jfrog.io/artifactory/jfrog-cli with default cache settings.
JFrog Xray version (if relevant)
N/A
Follow-up (non-failing mitigation)
#346 documents this behavior and adds a plain core.info line. It does not change URL construction, authentication, downloading, caching, exit status, or failure behavior.
- Lenguaje dominante
- TypeScript
- Estrellas
- 266
- Forks
- 110
- Merge medio
- 3 d 15 h
- PR fusionados (30 d)
- 3
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de jfrog/setup-jfrog-cli
-
Ghost mode continues to intercept commands after POST configuration step within GitHub Actions Abiertobug
Dificultad 3/5 1-2 días Aptitud para principiantes 58/100
jfrog/setup-jfrog-cli#349 ·
-
feature request
Dificultad 4/5 3-5 días Aptitud para principiantes 55/100
jfrog/setup-jfrog-cli#348 ·
-
Dificultad 3/5 1-2 días Aptitud para principiantes 68/100
jfrog/setup-jfrog-cli#343 · 1 reacción ·
-
bug
Dificultad 3/5 1-2 días Aptitud para principiantes 67/100
jfrog/setup-jfrog-cli#339 ·
-
(short feature description) Abiertofeature request
Dificultad 3/5 1-2 días Aptitud para principiantes 48/100
jfrog/setup-jfrog-cli#325 ·
Todos los issues de jfrog/setup-jfrog-cli
Issues similares
-
Dificultad 1/5 1-3 horas Aptitud para principiantes 88/100
motiondivision/motion#3849 ·
-
Add: S Play Event HD Abiertocheck:passed streams:add
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
-
Improvement for contact popover Abierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 68/100
-
LiteLLM proxy response_cost (x-litellm-response-cost) is never applied to ChatModelOutput.cost Abiertobug
Dificultad 2/5 1-3 horas Aptitud para principiantes 84/100
i-am-bee/beeai-framework#1697 · 1 reacción ·
-
Support bun dedupe Abiertoenhancement
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
antfu/node-modules-inspector#214 ·