Pinning should have a better UX for any time scale it takes to pin, and pinning intentions should be persisted between reboots

Abierto
#2,385 2 comentarios 1 reacción 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
5/5
Tiempo estimado
Más de una semana
Aptitud para principiantes
25/100
Tipo de issue
Nueva funcionalidad
Claridad
Necesita aclaración
Estado de actividad
Estancado
Stack tecnológico
javascript
Área
desktop

Línea de trabajo

Empieza por rastrear el flujo actual de pinning en IPFS Desktop y revisar cómo las solicitudes de pin sobreviven a los reinicios de la aplicación. Define los estados, el comportamiento de la cola en segundo plano y en primer plano, el manejo de reintentos y las notificaciones de finalización descritos aquí; se considera terminado cuando los pins retrasados, grandes y no disponibles siguen visibles y finalmente informan de su finalización sin perder la intención del usuario.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

effort/weeks exp/wizard kind/discussion kind/enhancement need/analysis need/community-input need/maintainers-input P2 topic/design-ux

This is a feature request for IPFS Desktop as I currently see this problem;

Pinning something falls either under three different "time scales".

The first is that the file is already locally downloaded, and pinning is nothing more than verifying that the file exists, this usually takes under a second.

The second is that the file is not completely downloaded, or not downloaded at all, but that it is easily accessible over the network (i.e. DHT announcements are out, content is easily findable, and its relatively small, only a few MB or so), this'd take a few seconds, but nothing more.

The third is that the file is not findable, the file is either not announced, the peers aren't reachable, or otherwise the pinning process takes an extra amount of time to complete, usually for multiple GB of data.

The last two is what IPFS Desktop does not feel ready for, the pinning checkmark feels like it has a roundtrip time of exactly the amount of time it takes to press it, and nothing more.

For pins that take a second more, the pinning state should be communicated clearly to the user, and replaced with a 'pinned' icon when it is done.

For pins that are stalled or take an incredibly long amount of time, the request that the user wants to pin this file should be persisted, so that they can simply tell IPFS "hey, i care about this file, find it, no matter how long it takes", that is what i expect it to do, and i've had multiple times where after a restart, IPFS Desktop forgot i wanted to pin the file, even ones that were actively downloading.


I'm currently using ipfs-cluster, which has this behaviour, where pin add tells it to queue up the pin, and try pinning it later, retrying other pins in a round-robin fashion ad infinitum, until one of them succeeds pinning, leaving others to take the place in the queue.

It has a relative prioritisation system, where a new pin is more eligible for the active-pinning queue than older pins. This is relatively annoying as it takes the timeout phase (24h by default) for the new pin to start getting pinned, so IMO a "background" and "foreground" queue should be created for IPFS Desktop to achieve a better user experience.


Pinning this way (in the background, in a long-form) should also generate notifications when the pin is complete, so the user can be somewhat aware when such a thing is finally done.

Lenguaje dominante
JavaScript
Estrellas
6.6k
Forks
908
Métricas de merge de PR
Sin PR fusionados en 30 d

Preparar el entorno

Este proyecto no incluye contenedor de desarrollo, Dockerfile ni guía de contribución, así que la configuración corre por tu cuenta: empieza por su README y consulta nuestra guía para la primera contribución para los pasos generales.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de ipfs/ipfs-desktop

Todos los issues de ipfs/ipfs-desktop

Issues similares

Más issues de JavaScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.