[unitrace] clarify installation artifacts and locations

Abierto
  • ¿Algo no está bien?
#124 1 comentario 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
20/100
Tipo de issue
Refactorización
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
linux, ubuntu
Área
build-system, release

Línea de trabajo

The layout to change is the install tree in the issue: bin/summary/ (including schemas/), etc/unitrace/metrics/config/, lib/libunitrace_tool.so, and the bin/addrasm.py, analyzeperfmetrics.py and mergetrace.py scripts. Find where the install step places these files in the repository's build or packaging scripts. Done means the maintainers have answered the four questions and the agreed paths are applied, so this needs a maintainer decision before any code change.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

On:

Below are unitrace installation artifacts:

/opt/install/
|-- bin
|   |-- addrasm.py
|   |-- analyzeperfmetrics.py
|   |-- mergetrace.py
|   |-- summary
|   |   |-- categorize.py
|   |   |-- schemas
|   |   |   |-- LLaMA.ini
|   |   |   `-- LLaMA.json
|   |   `-- summary.py
|   |-- unitrace
|   `-- uniview.py
|-- etc
|   `-- unitrace
|       `-- metrics
|           `-- config
|               |-- bmg
|               |   |-- ComputeBasic.txt
|               |   `-- MemoryProfile.txt
|               `-- pvc
|                   |-- ComputeBasic.txt
|                   |-- GpuOffload.txt
|                   |-- L1ProfileReads.txt
|                   |-- L1ProfileSlmBankConflicts.txt
|                   |-- L1ProfileWrites.txt
|                   `-- MemProfile.txt
`-- lib
    `-- libunitrace_tool.so

11 directories, 18 files

I have concerns that above layout will be acceptable to package unitrace for Linux distribution packaging:

  1. Some stuff installed into /usr/bin/ have too wide names without clear affiliation to unitrace. These are addrasm.py, analyzeperfmetrics.py, mergetrace.py. I would consider renaming them with some some kind of uni* prefix.
  2. What is the purpose of libunitrace_tool.so? It does not have associated development environment (header files) and there seem to be only one actual executable - unitrace. So why the library needs to be dynamic?
  3. Does user supposed to modify stuff landed in /etc/unitrace/metrics/config/? If yes - these are indeed configuration files. If not - then these are unitrace internal stuff and should be moved to /usr/lib/unitrace/ folder.
  4. /usr/bin/summary/* - this location is definitely not correct. This must be moved to /usr/lib/unitrace/

@androniychuk, do you have any other questions/comments for the above unitrace installation artifacts?

CC: @mschilling0

Lenguaje dominante
C++
Estrellas
278
Forks
74
Sin PR fusionados en 30 d

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de intel/pti-gpu

Todos los issues de intel/pti-gpu

Issues similares

Más issues de C++

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.