`--provider openai-codex` is offered by commands whose answerer or generator refuses it

Cerrado
  • ¿Algo no está bien?
#404 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Ya se ha fusionado un pull request relacionado.

  • #428 de @vlad-perevezentsev — fusionado

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
56/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
python
Área
ai, cli

Línea de trabajo

Start by reading the definitions of ANSWER_PROVIDERS and CALLER_PROVIDERS in dokimi.llm, then trace how the listed commands validate --provider and route it to the LLM. The issue offers two paths: accept openai-codex or remove it from command choices; accepting it requires confirming the model works through chat completions. Done means the commands no longer offer a provider they reject, with tests covering the selected behavior.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Found in the review of #384 (https://github.com/intel/dokimi/pull/384#discussion_r4473774384). Pre-existing: main behaves the same.

--provider on these commands takes llm.ANSWER_PROVIDERS, which includes openai-codex. The class each command builds checks llm.CALLER_PROVIDERS, which does not. So the run stops with ValueError: Unsupported provider: 'openai-codex':

Command Refused by
answers generate Answerer
questions generate QuestionGenerator
personas discover PersonaGenerator
evaluate, benchmark run, benchmark batch EvaluationPipeline → PersonaGenerator, QuestionGenerator, Answerer

dokimi.llm already routes the provider (openai/<model>, key OPENAI_API_KEY). The callers' tuples have left it out since before #384; that PR only merged the four copies into one constant.

Two ways to fix it, one PR:

  1. Accept it: add openai-codex to CALLER_PROVIDERS, with one test per command above that it reaches dokimi.llm with the openai/ route.
  2. Stop offering it: build these commands' --provider choices from CALLER_PROVIDERS (argparse then exits 2 before the run starts).

Option 1 needs someone to confirm that the models openai-codex names answer on that route through chat completions; if that is not known, option 2 is the safe one.

Lenguaje dominante
Python
Estrellas
11
Forks
9
Merge medio
1 d 10 h
PR fusionados (30 d)
373

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de intel/dokimi

Todos los issues de intel/dokimi

Issues similares

Más issues de Python

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.