Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

binder: `ServerStream.close()` marks the stream closed before the suffix is sent, so a flow-control-deferred send failure leaks the call

Abierto
  • ¿Algo no está bien?
#13,097 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
45/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
android, java
Área
backend-api-design

Línea de trabajo

Start with SingleMessageServerStream.close() and MultiMessageServerStream.close(), then trace ServerInbound.onCloseSent(), Inbound.onTransportReady(), and ServerOutbound.writeSuffix() in the Binder transport. Reproduce in Robolectric with BlackHoleOneWayBinderProxy to inspect deferred-close behavior. Done means deferred failures clean up the call, callbacks do not follow closed(), and tests cover the flow-control cases described.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

What version of gRPC-Java are you using?

master at c9ee3f8a79 (1.85.0-SNAPSHOT)

What is your environment?

Android

What did you expect to see?

If the server's close (status + trailers, plus any pending unary response) is deferred by transport flow control and the deferred send later fails, the stream should still end in the same clean way:

  • the client receives an out-of-band close
  • the call is removed from ongoingCalls so transport can be marked as no longer in use , and
  • the application is not told onComplete() for an RPC whose close was never sent.
  • Once closed() has been delivered to a ServerStreamListener, no further callbacks (onReady, in particular) should follow.
What did you see instead?

Both SingleMessageServerStream.close() and MultiMessageServerStream.close() do:

synchronized (outbound) {
  outbound.sendClose(status, trailers);   // or sendSingleMessageAndClose(...)
}
synchronized (inbound) {
  inbound.onCloseSent(status);
}

BinderTransport.isReady() is !flowController.isTransmitWindowFull(), a single 128 KiB window (TRANSACTION_BYTES_WINDOW) shared by every call on the transport. If another stream has filled it when close() runs, Outbound.canSend() is false, send() returns without writing, and the suffix stays queued until an ACKNOWLEDGE_BYTES arrives. inbound.onCloseSent() nevertheless runs immediately: it moves ServerInbound to State.CLOSED and calls listener.closed(Status.OK). Unregistration is deferred to ServerOutbound.writeSuffix(), which has not run.

When the window reopens, BinderTransport.handleAcknowledgedBytes() → Inbound.onTransportReady() first calls listener.onReady() (on a listener that has already been closed()), then outbound.onTransportReady() → sendInternal(). If that deferred send fails with a StatusException before reaching writeSuffix()'s unregister() — e.g. MetadataHelper.writeMetadata() throwing RESOURCE_EXHAUSTED: Metadata value too large for a stream-marshalled trailer value of BlockPool.BLOCK_SIZE (16 KiB) or more, an IOException from the response stream in writeMessageData(), or a RemoteException on a non-final chunk of a multi-block response — then Inbound.onTransportReady() catches it and calls closeAbnormal(se.getStatus()), which is guarded by if (!isClosed()) and is now a no-op.

Additionally, any subsequent OOB cancel from the client for that call is dropped by Inbound.handleTransaction()'s if (isClosed()) return;, so client-side cleanup cannot repair the server. If the deferred send succeeds, writeSuffix() calls unregister() before sendTransaction(), so the normal path and a RemoteException on the suffix transaction itself do not leak; only failures before that point do. If the deferred send throws an unchecked exception, it escapes into BinderTransport.handleTransaction()'s catch (RuntimeException) from #10092 and terminates the whole transport — not a leak, but a per-stream problem taking down every call on the connection.

Note that the premature closed(OK) and the post-close onReady() happen for every flow-control-deferred close, not only the ones whose deferred send later fails.

Steps to reproduce the bug

Difficult to reproduce on a real device. It can be done in robolectric using a BlackHoleOneWayBinderProxy to force flow-control to kick in.

Lenguaje dominante
Java
Estrellas
12.1k
Forks
4k
Merge medio
2 d 6 h
PR fusionados (30 d)
26

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de grpc/grpc-java

Todos los issues de grpc/grpc-java

Issues similares

Más issues de Java

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.