Bug: React-Map createCustomEqual no overloads matches call.

Abierto
  • ¿Algo no está bien?
#1,221 2 comentarios 2 reacciones 1 asignado Ver en GitHub

@amuramoto ya está trabajando en esto.

Desde el 8/7/2022.

Evaluación

Este issue todavía no se ha evaluado.

Descripción

Operating system

Windows 10 21H2

Browser Version

Firefox 102.0

How severe is the bug?

high

Bug description

Checking the custom hook for deep comparisons, the method createCustomEqual in deepCompareEqualsForMaps (line 213, in react-maps/docs/index.tsx), does not recognize both a and b:

(deepEqual) => (a: any, b: any)

throws the following error:

No overload matches this call.
  Overload 1 of 2, '(getComparatorOptions: GetComparatorOptions<undefined>): <A, B>(a: A, b: B, meta?: undefined) => boolean', gave the following error.
    Value of type '(a: any, b: any) => any' has no properties in common with type 'Partial<CreateComparatorCreatorOptions<undefined>>'. Did you mean to call it?
  Overload 2 of 2, '(getComparatorOptions: GetComparatorOptions<undefined>): <A, B>(a: A, b: B, meta?: undefined) => boolean', gave the following error.
    Value of type '(a: any, b: any) => any' has no properties in common with type 'Partial<CreateComparatorCreatorOptions<undefined>>'. Did you mean to call it?ts(2769),

index.d.ts(16, 42): The expected type comes from the return type of this signature.
index.d.ts(16, 42): The expected type comes from the return type of this signature.

And also the deepEqual(a , b); call throws the error:

This expression is not callable.
  Type 'CreateComparatorCreatorOptions<undefined>' has no call signatures.ts(2349)

I guess both things are related to some Typescript error using fast-equals library. I also tried cloning the repository and the same problems are still showing up.

Steps to reproduce

No response

Console log output

No response

Lenguaje dominante
TypeScript
Estrellas
804
Forks
826
Sin PR fusionados en 30 d

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de googlemaps/js-samples

Todos los issues de googlemaps/js-samples

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.