aiohttp timeout and wrapped google-auth transport exceptions are not retried despite HttpRetryOptions being configured

Abierto
  • ¿Algo no está bien?
#3,329 1 comentario 0 reacciones 1 asignado Ver en GitHub

Los mantenedores suelen responder en 1 día

@Venkaiahbabuneelam ya está trabajando en esto.

Desde el 11/11/2026.

  • #3330 de @rladeira — abierto
  • #3332 de @copybara-service — abierto

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
72/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
python
Área
api, backend

Línea de trabajo

Start in google/genai/_api_client.py at retry_args() and _AIOHTTP_TRANSIENT_EXC, then trace _async_request_once() to understand how authenticated transport exceptions are handled. Reproduce the listed predicates and add coverage for the timeout and wrapped transport cases, while checking that payload and refresh errors remain non-retryable and the no-retry_options path is unchanged.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

priority: p2 type: bug
Describe the bug

When HttpRetryOptions is configured and aiohttp is used as the async HTTP transport (google-genai[aiohttp]), request timeouts and wrapped google.auth.aio transport exceptions bypass retry_args() and fail on the first attempt without retrying.

Specifically:

  1. asyncio.TimeoutError (and aiohttp.ServerTimeoutError / aiohttp.ConnectionTimeoutError):
    While _HTTPX_TRANSIENT_EXC includes httpx.TimeoutException and httpx2.TimeoutException (added in #2345 for #2337), _AIOHTTP_TRANSIENT_EXC only lists (aiohttp.ClientConnectorError, aiohttp.ClientOSError, aiohttp.ServerDisconnectedError). In aiohttp, ClientTimeout(total=...) (TimerContext.__exit__) raises asyncio.TimeoutError directly, and aiohttp.ServerTimeoutError / ConnectionTimeoutError inherit from (aiohttp.ClientConnectionError, asyncio.TimeoutError), not ClientConnectorError, ClientOSError, or ServerDisconnectedError.
  2. google.auth.exceptions.TimeoutError (auth_exceptions.TimeoutError):
    When Vertex AI mTLS is used (_use_google_auth_async() == True), _get_aiohttp_session() returns google.auth.aio.transport.sessions.AsyncAuthorizedSession. Both google.auth.aio.transport.aiohttp.Request.__call__ and google.auth.aio.transport.sessions.timeout_guard catch asyncio.TimeoutError and raise google.auth.exceptions.TimeoutError (which inherits from GoogleAuthError, not builtins.TimeoutError or aiohttp.ClientError).
  3. google.auth.exceptions.TransportError wrapping _AIOHTTP_TRANSIENT_EXC:
    Under AsyncAuthorizedSession, google.auth.aio.transport.aiohttp.Request.__call__ catches aiohttp.ClientError and raises google.auth.exceptions.TransportError(...) from caught_exc. In _async_request_once(), the except (..., auth_exceptions.TransportError) block re-raises when retry_options is configured (raise # HttpRetryOptions owns retries; tenacity decides.), but retry_args() does not match auth_exceptions.TransportError wrapping _AIOHTTP_TRANSIENT_EXC.
Steps to reproduce
import asyncio
from google.auth import exceptions as auth_exceptions
from google.genai import _api_client as api_client
from google.genai import types
import aiohttp

retry = api_client.retry_args(types.HttpRetryOptions())['retry']
print("asyncio.TimeoutError retried:", retry.predicate(asyncio.TimeoutError()))
print("aiohttp.ServerTimeoutError retried:", retry.predicate(aiohttp.ServerTimeoutError()))
print("google.auth.exceptions.TimeoutError retried:", retry.predicate(auth_exceptions.TimeoutError("Request timed out")))

Output on main:

asyncio.TimeoutError retried: False
aiohttp.ServerTimeoutError retried: False
google.auth.exceptions.TimeoutError retried: False
Expected behavior

When HttpRetryOptions is configured, retry_args() should retry asyncio.TimeoutError (including aiohttp.ServerTimeoutError and aiohttp.ConnectionTimeoutError), google.auth.exceptions.TimeoutError, and google.auth.exceptions.TransportError whose __cause__ is in _AIOHTTP_TRANSIENT_EXC, matching the httpx.TimeoutException behavior from #2337 / #2345 while keeping non-transient errors (such as aiohttp.ClientPayloadError and google.auth.exceptions.RefreshError) and the no-retry_options path unchanged.

Lenguaje dominante
Python
Estrellas
4.1k
Forks
1.1k
Merge medio
1 d 20 h
PR fusionados (30 d)
90

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de googleapis/python-genai

Todos los issues de googleapis/python-genai

Issues similares

Más issues de Python

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.