Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

FunctionDeclaration.from_callable drops enum and properties from Optional[...] parameters

Abierto Apto para principiantes
  • ¿Algo no está bien?
#3,105 1 comentario 0 reacciones 1 asignado Ver en GitHub

Los mantenedores suelen responder en 1 día

@Venkaiahbabuneelam ya está trabajando en esto.

Desde el 13/10/2026.

Evaluación

Dificultad
2/5
Tiempo estimado
1-3 horas
Aptitud para principiantes
67/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
python
Área
api, backend

Línea de trabajo

Lee _automatic_function_calling_util.py en torno a _parse_schema_from_parameter y la reducción de Union con un único miembro cerca de la línea 282. Compara Optional y la unión con barra vertical examples del issue y añade casos de regresión a tests/types/test_types.py para parámetros Literal y de modelo opcionales. La tarea está terminada cuando los esquemas generados conservan las propiedades enum u objeto y siguen siendo nullable.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

priority: p2 type: bug

FunctionDeclaration.from_callable keeps only the type of the inner schema when a parameter is Optional[X]. An Optional[Literal["c", "f"]] parameter becomes a nullable string with no enum. An Optional[Address] parameter becomes a bare nullable object with no properties or required. Address | None keeps them, but Literal["c", "f"] | None loses its enum too.

import json
from typing import Literal, Optional
import pydantic
from google import genai
from google.genai import types

client = genai.Client(api_key="not-a-real-key")  # no request is sent

class Address(pydantic.BaseModel):
  city: str

def unit_plain(unit: Literal["c", "f"]) -> str: ...
def unit_optional(unit: Optional[Literal["c", "f"]] = None) -> str: ...
def addr_optional(addr: Optional[Address] = None) -> str: ...
def addrs_optional(addrs: Optional[list[Address]] = None) -> str: ...
def unit_pipe(unit: Literal["c", "f"] | None = None) -> str: ...
def addr_pipe(addr: Address | None = None) -> str: ...

for f in [unit_plain, unit_optional, addr_optional, addrs_optional, unit_pipe, addr_pipe]:
  fd = types.FunctionDeclaration.from_callable(client=client, callable=f)
  (name, s), = fd.parameters.properties.items()
  print(f"{f.__name__:15}", json.dumps(s.model_dump(exclude_none=True)))

$ python -I genai_fd3.py
unit_plain      {"enum": ["c", "f"], "type": "STRING"}
unit_optional   {"nullable": true, "type": "STRING"}
addr_optional   {"nullable": true, "type": "OBJECT"}
addrs_optional  {"items": {"properties": {"city": {"type": "STRING"}}, "required": ["city"], "type": "OBJECT"}, "nullable": true, "type": "ARRAY"}
unit_pipe       {"nullable": true, "type": "STRING"}
addr_pipe       {"nullable": true, "properties": {"city": {"type": "STRING"}}, "required": ["city"], "type": "OBJECT"}
# google-genai 2.29.0 at 6a6501c (main, 2026-10-11), CPython 3.12.3, Linux x86_64

The single-member collapse in the Union branch of _parse_schema_from_parameter (_automatic_function_calling_util.py:282) copies schema.any_of[0].type and nothing else. Optional[list[...]] survives only because the lines above it copy items by hand. Copying the whole member fixes both:

       if len(schema.any_of) == 1:  # param: Union[List, None] -> Array
-        schema.type = schema.any_of[0].type
-        schema.any_of = None
+        schema = schema.any_of[0].model_copy(
+            update={'nullable': schema.nullable}
+        )

$ python -I genai_fd3.py   # with the patch
unit_plain      {"enum": ["c", "f"], "type": "STRING"}
unit_optional   {"enum": ["c", "f"], "nullable": true, "type": "STRING"}
addr_optional   {"nullable": true, "properties": {"city": {"type": "STRING"}}, "required": ["city"], "type": "OBJECT"}
addrs_optional  {"items": {"properties": {"city": {"type": "STRING"}}, "required": ["city"], "type": "OBJECT"}, "nullable": true, "type": "ARRAY"}
unit_pipe       {"enum": ["c", "f"], "nullable": true, "type": "STRING"}
addr_pipe       {"nullable": true, "properties": {"city": {"type": "STRING"}}, "required": ["city"], "type": "OBJECT"}

$ python -m pytest -q google/genai/tests/types/test_types.py google/genai/tests/types/test_future.py
95 passed, 6 skipped, 2 warnings     # same count before and after the patch
# not run: any request to the live API

This is the default use_json_schema=False path, so it hits direct from_callable callers. A function passed straight into tools=[...] takes use_json_schema=True (_transformers.py:961), where open #3074 and #3093 work. @Venkaiahbabuneelam, CONTRIBUTING.md says outside pull requests are not taken yet, so the diff above is the whole proposal. Would a test for these signatures in tests/types/test_types.py help it land?

Lenguaje dominante
Python
Estrellas
4k
Forks
1k
Merge medio
1 d 6 h
PR fusionados (30 d)
88

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de googleapis/python-genai

Todos los issues de googleapis/python-genai

Issues similares

Más issues de Python

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.