Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

spanner: requiring @google-cloud/spanner stops the process from exiting on SIGTERM/SIGINT

Abierto Apto para principiantes
  • ¿Algo no está bien?
#9,513 0 comentarios 0 reacciones 1 asignado Ver en GitHub

Los mantenedores suelen responder en 1 día

@alkatrivedi ya está trabajando en esto.

Desde el 13/10/2026.

Evaluación

Dificultad
2/5
Tiempo estimado
1-3 horas
Aptitud para principiantes
78/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
nodejs, typescript
Área
backend

Línea de trabajo

Comienza con handwritten/spanner/src/index.ts, donde se registran los listeners de SIGINT y SIGTERM, y ejecuta la reproducción mínima enlazada con npm install && npm test. Confirma el comportamiento del proceso con y sin @google-cloud/spanner; se considera terminado cuando cargar la biblioteca ya no impide el comportamiento esperado de apagado tras una señal.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

api: spanner
Please make sure you have searched for information in the following guides.
Library Name

@google-cloud/spanner

A screenshot that you have tested with "Try this API".

Not API related

Link to the code that reproduces this issue. A link to a public Github Repository or gist with a minimal reproduction.

https://gist.github.com/wildan2711/1630361a07bd531792be280519d8e3fa

A step-by-step description of how to reproduce the issue, based on the linked reproduction.

Runnable reproduction: https://gist.github.com/wildan2711/1630361a07bd531792be280519d8e3fa (npm install && npm test)

Minimal version:

// repro.js
require('@google-cloud/spanner');
console.log('SIGTERM listeners:', process.listenerCount('SIGTERM'));
setInterval(() => {}, 1000); // anything that keeps the event loop alive, e.g. an HTTP server

node repro.js &
kill -TERM $!   # process keeps running
kill -INT  $!   # still running; only SIGKILL stops it

Remove the require line and the same script exits on SIGTERM as expected.

A clear and concise description of what the bug is, and what you expected to happen.

Requiring @google-cloud/spanner makes a long-running Node.js process ignore SIGTERM and SIGINT. When the module loads, it registers process.on('SIGINT') and process.on('SIGTERM') listeners in handwritten/spanner/src/index.ts that run the metrics cleanup() but never exit or re-raise the signal. The process then keeps running until it gets SIGKILL. This applies even if no Spanner client is ever created. In practice, Cloud Run, GKE and App Engine instances run until the end of the shutdown grace period instead of stopping, docker stop and process managers leave orphaned processes holding their ports, and Ctrl+C doesn't stop a dev server.

Expected: loading the library doesn't change how the process responds to signals. A process that would exit on SIGTERM or SIGINT without @google-cloud/spanner should still exit with it.

A clear and concise description WHY you expect this behavior, i.e., was it a recent change, there is documentation that points to this behavior, etc. **
  • It's a regression. 8.0.0 registers no signal listeners and the process exits normally. The listeners first appear in 8.1.0 and are still present in 9.0.0 and on main. We noticed when upgrading from 6.x to 8.6.0: our services stopped shutting down on SIGTERM.
  • Node.js documents this effect. Per the signal events docs, "SIGTERM and SIGINT have default handlers on non-Windows platforms that reset the terminal mode before exiting with code 128 + signal number. If one of these signals has a listener installed, its default behavior will be removed (Node.js will no longer exit)." So any listener that doesn't exit stops the process from shutting down.
  • The code's own comment says the process should exit. It reads // For signals (let process exit naturally), which shows the listeners were meant to flush metrics without blocking shutdown. But a process with an open server, socket or timer never exits "naturally", so in practice they block it.
  • Libraries generally shouldn't own process signals. Shutdown on SIGTERM and SIGINT belongs to the application or its framework, which may need its own graceful-shutdown logic. A dependency that silently disables the default makes that impossible to see, and the only workaround is removing the listeners by hand.
Lenguaje dominante
TypeScript
Estrellas
3.2k
Forks
724
Merge medio
2 d 55 min
PR fusionados (30 d)
158

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de googleapis/google-cloud-node

Todos los issues de googleapis/google-cloud-node

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.