codegen: an `array[N] ptr array[M] T` argument is declared as `T* a_p)[M]`

Abierto
  • ¿Algo no está bien?
#263 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
1-2 días
Aptitud para principiantes
57/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
c
Área
compilers

Línea de trabajo

Read internal/cgen/expr.go around lines 611–620 and 649–678, where the issue identifies the type handling and declarator dimensions. Use the provided Wuffs repro to generate C, then check that the result is a valid declarator such as uint8_t (*a_p[2])[3] or that generation reports an error. Confirm the generated C compiles with a C compiler.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Hi,

General context of this work is in #188, including the AI-disclaimers.

No in-tree codec is affected by this issue; no std function has an argument that is an array of pointers to arrays. Claude judges the prospective risk of it as "low": the generated C does not compile, and the related nestings fail generation.

The following is Sol 6.1's writeup of the issue. Includes a repro, the generated declarator, compile errors from gcc 13.3, clang 18, MSVC and clang-cl 18, a control that compiles, and generation errors for two other nestings. The cause is reasoned from source.

For an array[2] ptr array[3] base.u8 argument, cgen emits uint8_t* a_p)[3], with an unmatched parenthesis and no outer array dimension. writeCTypeName strips the outer arrays before recognizing the pointer to an array, but writes the closing parenthesis and dimensions from the full type.

Minimal repro:

pub struct repro?(
    buf : array[4] base.u8,
)

pub func repro.f!(p: array[2] ptr array[3] base.u8) {
    args.p[0][1] = 7
}

Actual: at b36a81d3, wuffs-c gen -package_name repro arr_ptr_arr.wuffs exits 0 with empty stderr. The prototype is:

wuffs_repro__repro__f(
    wuffs_repro__repro* self,
    uint8_t* a_p)[3]);

Compiling the amalgamation with WUFFS_IMPLEMENTATION defined fails with gcc 13.3 (-std=c99 -c, exit 1), clang 18 (exit 1), MSVC (cl /c, exit 2) and clang-cl 18 (exit 1):

arr_ptr_arr-release.c:7939:1: error: ‘wuffs_repro__repro__f’ declared as function returning an array
arr_ptr_arr-release.c:7941:21: error: expected declaration specifiers before ‘)’ token
arr_ptr_arr-release.c:7941:21: error: expected function body after function declarator
arr_ptr_arr-release.c(7941): error C2059: syntax error: ')'
arr_ptr_arr-release.c(7939): error C2090: function returns array
arr_ptr_arr-release.c(7941,21): error: expected function body after function declarator

Control: a ptr array[3] base.u8 argument, without the outer array, is emitted as uint8_t* a_p and compiles. Two other nestings fail generation: ptr array[2] ptr base.u8 and ptr ptr array[3] base.u8 arguments produce cannot convert Wuffs type "ptr array[2] ptr base.u8" to C and cannot convert Wuffs type "ptr ptr array[3] base.u8" to C.

Expected: either a valid declarator for an array of pointers to arrays, such as uint8_t (*a_p[2])[3], or a generation error.

Cause: the outer arrays are stripped into x, and the pointer-to-array case is recognized on x:

https://github.com/google/wuffs/blob/b36a81d3352604fee1fee3661f39909706b1b966/internal/cgen/expr.go#L611-L620

The closing parenthesis and dimensions are then written from n, the full type. The outer array shifts what x.Inner().Inner() refers to:

https://github.com/google/wuffs/blob/b36a81d3352604fee1fee3661f39909706b1b966/internal/cgen/expr.go#L649-L678

Lenguaje dominante
C
Estrellas
4.9k
Forks
150
Merge medio
4 d 1 h
PR fusionados (30 d)
3

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de google/wuffs

Todos los issues de google/wuffs

Issues similares

Más issues de C

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.