Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

[spring-ai] Wrapping ChatModels without getOptions() override fail with ClassCastException when ADK tools are attached

Abierto
  • ¿Algo no está bien?
#1,731 0 comentarios 0 reacciones 1 asignado Ver en GitHub

Los mantenedores suelen responder en 1 día

@hirematha ya está trabajando en esto.

Desde el 30/10/2026.

Evaluación

Este issue todavía no se ha evaluado.

Descripción

Describe the Bug

When the configured ChatModel is a delegating/wrapping implementation that does not override getOptions() (the interface default returns an empty DefaultChatOptions), any ADK request with tools fails with a bare ClassCastException deep inside the provider model.

Chain:

  1. SpringAI.resolveDefaultOptions() returns the model's getOptions() — for wrappers, the interface default: an empty DefaultChatOptions, not null, so the existing null handling never engages;
  2. MessageConverter.buildChatOptions(...) sees defaults that are not ToolCallingChatOptions and falls into the hasTools branch, building provider-neutral ToolCallingChatOptions;
  3. Provider models that cast Prompt.getOptions() to their own type — e.g. OpenAiChatModel.createRequest(...) casting to OpenAiChatOptions — throw ClassCastException: DefaultToolCallingChatOptions cannot be cast to OpenAiChatOptions.

The failure surfaces several frames away from the cause and gives no hint that the wrapper's getOptions() is the origin. We hit this in production with a failover wrapper (2026-09-28): the non-streaming fallback path died on its first call.

Note the related hardening in resolveDefaultOptions() (avoiding the same cast by using the model's own options) covers the "options available" half; this report is the "defaults are the empty interface default" half.

To Reproduce
// Any delegating wrapper that forgets to override getOptions()
class ForgettingWrapper implements ChatModel, StreamingChatModel {
  private final ChatModel delegate;
  // call()/stream() delegate; getOptions() intentionally NOT overridden
}

SpringAI springAI = new SpringAI(new ForgettingWrapper(openAiChatModel));
springAI.generateContent(
    LlmRequest.builder()
        .contents(List.of(userContent("hello")))
        .tools(Map.of("ping", pingTool))   // any ADK tool
        .build(),
    false);
// -> RuntimeException wrapping ClassCastException:
//    DefaultToolCallingChatOptions cannot be cast to org.springframework.ai.openai.OpenAiChatOptions

(Verified with a probe test on current main: the wrapper's getOptions() returns DefaultChatOptions@..., instanceof ToolCallingChatOptions is false, and the cast fails exactly as above.)

Expected behavior

At minimum, an actionable warning/error at the bridge level naming the actual cause ("the wrapping model's getOptions() returns non-provider options; delegate it to the underlying model's options"), instead of a bare ClassCastException from inside the provider. Fail-fast would also be reasonable, except that dummy/test models legitimately use the same default — so we prototyped a WARN in MessageConverter.buildChatOptions (branch: https://github.com/google/adk-java/compare/main...caps-xia:adk-java:fix/wrapper-chatmodel-options-cce, 307 tests green) and are happy to open a PR if the direction sounds right.

Environment
  • google/adk-java main (post the resolveDefaultOptions hardening)
  • Spring AI 2.0.1, spring-ai-openai
Additional context

Wrapping/decorating ChatModels (failover, retry, caching, audit) are a common Spring AI pattern; any of them without an explicit getOptions() override hits this the moment ADK tools are attached. A one-line doc note in the SpringAI README ("wrappers must delegate getOptions()") would also help.

Lenguaje dominante
Java
Estrellas
1.8k
Forks
442
Merge medio
3 d 13 h
PR fusionados (30 d)
95

Preparar el entorno

Abrir en Codespaces

Inicia el contenedor de desarrollo del proyecto en tu navegador, con tu propia cuenta de GitHub.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de google/adk-java

Todos los issues de google/adk-java

Issues similares

Más issues de Java

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.