broken submodule support: Initializes a fresh git repository at an incorrect path instead of opening the correct one if the godot project is a submodule

Abierto
#335 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
66/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
cpp
Área
tooling

Línea de trabajo

Reproduce the issue using the listed steps: open a Godot project installed in a Git submodule and observe where the plugin initializes its repository. Read the attached analysis and patch, then trace the plugin's repository-opening and initialization entry point to understand how it resolves the submodule path. Done means the plugin opens the submodule's repository rather than creating a repository in the parent repository's .git hierarchy.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

bug
Godot version

4.7.2.stable.arch_linux.ed1daf0bf

Godot Git Plugin version

4113e1109353e7f5ff23f29147e1d9b5588c4cee

System information

Archlinux

Issue description

godot-git-plugin does not work correctly if the godot project it is used in is itself a submodule - it will fail to open the submodule repository and instead initialize a new git repository within the parent repository's .git/ hierarchy.

(The use case is using godot-git-plugin in the demo scene for a godot plugin I'm developing, where the plugin is the main repository and the demo scene is a submodule in it - godot-git-plugin would be helpful here for having less-technical coworkers more easily tweak and extend the demo scene.)

I set a local Qwen3.8 instance on looking into this and fixing it and am attaching its analysis and the patch it produced (effectively, it's just a few lines), in case you find them helpful - the patch looks reasonable to me and seems to indeed solve this issue for me. (Since I'm neither familiar with the library used nor with the internals of godot-git-plugin myself, I won't pursue a PR, though.)

ai_analysis.txt
a9891dbcef.patch

Steps to reproduce
  • Create a git repository
  • add another git repository as submodule
  • in the submodule: create a godot project and install godot-git-plugin
  • observe that the plugin initializes a git repository somewhere in the parent repository's .git/ hierarchy instead of correctly opening the submodule
Lenguaje dominante
C++
Estrellas
966
Forks
100
Métricas de merge de PR
Sin PR fusionados en 30 d

Preparar el entorno

Este proyecto no incluye contenedor de desarrollo, Dockerfile ni guía de contribución, así que la configuración corre por tu cuenta: empieza por su README y consulta nuestra guía para la primera contribución para los pasos generales.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de godotengine/godot-git-plugin

Todos los issues de godotengine/godot-git-plugin

Issues similares

Más issues de C++

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.