Static $__joinPoint keeps the first instance of every woven class alive

Cerrado
  • ¿Algo no está bien?
#796 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Ya se ha fusionado un pull request relacionado.

  • #802 de @lisachenko — fusionado

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
22/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
php
Área
backend

Línea de trabajo

Start with the generated static $__joinPoint initialiser and AbstractMethodInvocation::$closureToCall, then read DynamicTraitAliasMethodInvocation::resolveOriginalMethod(), which uses the closure only to find the method. Reproduce the leak with the WeakReference snippet from the issue. Done means the first instance is collectable after gc_collect_cycles() without changing invocation results, and composer test:performance shows no regression. A linked pull request (#802) already exists, so check it before starting.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Bug PHP-8.4 PHP-8.5 PHP-8.6

What happens

Each intercepted instance method creates its joinpoint once, in a function-scoped static:

static $__joinPoint = InterceptorInjector::forMethod(
    self::class, 'sum', [...],
    $this->sumOriginalAlias(...),   // captures $this of the first call
);

The first-class callable captures the object of the first call. It is stored in AbstractMethodInvocation::$closureToCall (protected readonly Closure) and never released, so that object can't be garbage-collected until the end of the request:

$a = new Calc(); $a->sum(1, 1); $wa = WeakReference::create($a); unset($a); gc_collect_cycles();
$b = new Calc(); $b->sum(1, 1); $wb = WeakReference::create($b); unset($b); gc_collect_cycles();
var_dump($wa->get() !== null, $wb->get() !== null); // true, false: the first instance is still alive

The cost is one object per intercepted method, plus whatever that object references: entities, request objects, large graphs. Destructors of those objects run late. This isn't specific to PHP 8.6; it was found while checking whether PFA could replace this callable. PFA can't: 8.6 has no placeholder for $this, which the PFA RFC lists as future scope.

Cause

DynamicTraitAliasMethodInvocation only uses the closure to find the method: resolveOriginalMethod() reads the scope class and name, then calls ReflectionMethod::invokeArgs() on the current instance. The captured $this is never used.

Proposed fix (options)

  1. Pass the alias name instead of a callable, for example InterceptorInjector::forMethod(self::class, 'sum', [...], 'sumOriginalAlias'), and resolve new ReflectionMethod(self::class, 'sumOriginalAlias') lazily. For inherited methods without an alias, resolve the prototype from the parent class. This needs a migration path for the forMethod() signature and for existing caches.
  2. Smaller fix: unset the closure after resolveOriginalMethod(). This needs $closureToCall to stop being readonly for dynamic invocations, and it only frees the instance after the first call reaches the original body. An around advice that never proceeds keeps it alive.

Option 1 also makes the generated code a bit smaller. Check it with composer test:performance, since this touches the hot path.

Part of #789.

Lenguaje dominante
PHP
Estrellas
1.7k
Forks
166
Merge medio
1 d 1 h
PR fusionados (30 d)
43

Preparar el entorno

Este proyecto no incluye contenedor de desarrollo, Dockerfile ni guía de contribución, así que la configuración corre por tu cuenta: empieza por su README y consulta nuestra guía para la primera contribución para los pasos generales.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de goaop/framework

Todos los issues de goaop/framework

Issues similares

Más issues de PHP

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.