[repo-assist:issue-triage] githubnext/gh-cao issue 20097 triage guidance

Abierto
  • ¿Algo no está bien?
#20,103 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
Medio día
Aptitud para principiantes
15/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
javascript
Área
documentation, frontend

Línea de trabajo

Start with the aicc branch of formatNumber in dashboard/site/src/view-formatters.js, which calls formatAicc after rounding to 2 significant figures. Then read DLS-UNIT-004 in docs/dashboard-language-specification.md, since the spec mandates that rounding and a maintainer must approve any change before code is touched. Done means 39 AIC renders $0.39, the formatter tests and significant: 2 fixtures are updated, and the dashboard test suite passes.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

repo-assist repo-assist:issue-triage

Target githubnext/gh-cao issue 20097 (Cost page AIC rounding): the behavior is real but spec-mandated, so a fix needs a maintainer decision on DLS-UNIT-004 first. Confidence: high.

Action: A dashboard maintainer should decide whether to amend DLS-UNIT-004 (cents-grain rounding); if approved, assign the issue to Copilot with the prompt below. Acceptance: 39 AIC renders $0.39, 117 AIC renders $1.17, and dashboard unit tests and npm run check pass.

Evidence
  • docs/dashboard-language-specification.md DLS-UNIT-004 requires an aicc presenter to round the AIC value to significant: 2 before dividing by 100. 39 AIC becomes 40 and renders $0.40, matching the report.
  • dashboard/site/src/view-formatters.js formatNumber calls formatAicc(rounded) for aicc units, which implements that rule. It is not an implementation bug.
  • Rounding to 2 AIC gives $0.02 granularity, so sums of displayed parts cannot reconcile with totals. Rounding after the divide by 100 (cents) fixes this.
  • Rejected: tooltip-only unrounded AIC. It leaves the visible figures inconsistent.
  • Breaking-spec risk: changing a MUST rule requires updating the spec, docs/, formatter tests and contract fixtures together.
Agent prompt

In githubnext/gh-cao, change aicc formatting so the AIC value is divided by 100 and then rounded to cents, instead of being rounded to 2 AIC first. Update formatNumber in dashboard/site/src/view-formatters.js, amend DLS-UNIT-004 in docs/dashboard-language-specification.md, and update any significant: 2 fixtures or tests. Add a unit test showing 39 AIC renders $0.39 and three of them sum to $1.17. Run npm test, npm run lint and npm run typecheck in dashboard/site/, then npm run docs:build.

Control Plane

cao: githubnext/gh-cao, correlation: 41444087799-128

Generated by 🏷️ Repo Assist / Issue Triage · copilot · auto · ~20 AIC · ⌖ ~1 AIC · ⊞ 14K · ◷

  • expires on Nov 16, 2026, 12:32 PM UTC
Lenguaje dominante
JavaScript
Estrellas
14
Forks
5
Merge medio
3 h 24 min
PR fusionados (30 d)
796

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de githubnext/gh-cao

Todos los issues de githubnext/gh-cao

Issues similares

Más issues de JavaScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.