Partial merge leaves stale stack base and Rebase stack replays merged commits
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Aptitud para principiantes
- 42/100
Línea de trabajo
Comienza rastreando las rutas de merge-queue admission y Rebase stack, centrándote en cómo se actualiza el base SHA del objeto Stack después de una fusión parcial. Reproduce el escenario de ocho PR y revisa la base ref y el SHA informados antes y después de Rebase stack. Se considera completado cuando el stack restante apunta al commit actual de main, admite un sufijo verificado y no vuelve a reproducir commits fusionados.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Reproduction
- Create a stack with a merge queue on
main. - Merge a bottom prefix of the stack, leaving eight pull requests open.
- Rebase the eight remaining branches locally onto the current
main, then force-push them as one atomic ref update. - Verify that the lowest open branch is one commit ahead of
main, zero commits behind, and that every higher branch contains the branch below it. - Verify that every open pull request is approved and has passing required checks.
- Enqueue the remaining stack from its top pull request.
All eight pull requests entered the queue within one second. Eighteen seconds later, the lowest open pull request was removed with:
github-merge-queue removed this pull request from the merge queue due to invalid changes in the merge commit
Every higher pull request was then removed because an earlier pull request in the stack was removed. No merge_group workflow was created.
The stack merge box reported that the stack was out of date with main. The pull request API reported stack.base.ref = main, but stack.base.sha still identified the last layer of the already-merged prefix rather than the current main commit.
- Click Rebase stack in the GitHub UI.
The UI reported that all eight branches were rebased and that the stack had a linear history. The actual lowest branch changed from one commit ahead and zero behind to 16 commits ahead and 15 behind. Commits already present on main reappeared in the pull request.
Expected
After a partial stack merge, GitHub updates the remaining stack's base to the current main commit and retargets the lowest open pull request to main, as described in Merging stacked pull requests.
A locally verified linear suffix based on current main should enter the merge queue. Rebase stack must use the current base commit and must not replay commits that already landed.
Actual
The remaining stack retains a stale base SHA after the partial merge. Merge-queue admission rejects a correct branch graph before creating a merge group. Rebase stack then rewrites the branches against the stale anchor and reintroduces already-merged commits.
Recovery requires restoring every branch ref, removing the stale Stack object, retargeting the lowest open pull request to main, and linking the same pull requests into a new stack.
Environment
- GitHub Stacked Pull Requests public preview.
- GitHub merge queue.
- Original stack: 26 pull requests, with 18 merged and eight open.
- All open pull requests approved and required checks passing.
gh stackv0.1.0.gh2.96.0.- git 2.50.1.
- macOS arm64.
Related
- #174 concerns approval invalidation after a partial merge. Approvals remained valid in this reproduction.
- #444 concerns a pull request being closed at a merge-group boundary. The remaining pull requests stayed open in this reproduction, but the stack base remained stale.
- Lenguaje dominante
- Go
- Estrellas
- 1.5k
- Forks
- 73
- Merge medio
- 1 d 8 h
- PR fusionados (30 d)
- 7
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de github/gh-stack
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 85/100
-
Dificultad 1/5 Menos de una hora Aptitud para principiantes 92/100
-
feature request topic: cli - general
Dificultad 2/5 1-3 horas Aptitud para principiantes 68/100
-
feature request topic: auto-merge
Dificultad 2/5 1-3 horas Aptitud para principiantes 68/100
-
bug topic: docs
Dificultad 1/5 Menos de una hora Aptitud para principiantes 68/100
Todos los issues de github/gh-stack
Issues similares
-
Remove PSPs from Helm chart Abiertofeature-request helm
Dificultad 2/5 1-3 horas Aptitud para principiantes 68/100
gravitational/teleport#69785 ·
-
bug
Dificultad 1/5 Menos de una hora Aptitud para principiantes 92/100
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 84/100
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 88/100
crossplane/crossplane#7859 ·
-
Dificultad 1/5 Menos de una hora Aptitud para principiantes 90/100