Inserting a layer in the middle of a stack requires unstack + link, which permanently drops merged PRs
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 5/5
- Tiempo estimado
- Más de una semana
- Aptitud para principiantes
- 48/100
Línea de trabajo
Empieza reproduciendo el comportamiento reportado de gh stack link y gh stack unstack; después inspecciona la limitación de REST PATCH /repos/{o}/{r}/pulls/{n} y el flujo existente de pertenencia al stack. Se considera terminado cuando una inserción en mitad del stack o una reconstrucción sin pérdidas conserva la pertenencia de los PR fusionados y mantiene intacto todo el historial del stack.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Summary
There is no way to insert a layer in the middle of an already-submitted stack while keeping the stack's merged PRs as members. The only working procedure (unstack + link) moves the still-open PRs into a new stack and leaves every merged PR behind in the old one, which is then closed. The historical grouping of the stack is lost, permanently and irreversibly.
Current behavior
Given a submitted stack S with, bottom to top, one merged PR #1 and open PRs #2 → #3 → #4, and the need to insert a new layer between #2 and #3:
gh stack modifyis TUI-only, so it is unusable non-interactively (and it restructures the local stack, not the server-side membership of an existing PR).- Retargeting the base of an existing stacked PR is refused:
- REST
PATCH /repos/{o}/{r}/pulls/{n}→HTTP 422 … PullRequest.base is invalid gh pr edit <n> --base <branch>→Cannot change the base branch because the pull request is part of a stack
- REST
gh stack linkonly appends to the top (gh stack link <stack#> <new>); it has no position/insert argument, and it rejects arguments that belong to a different stack.- So the only way out is
gh stack unstack <S>+gh stack link <bottom> … <top>.unstack(v0.1.0) unstacks the open PRs and leaves the merged#1inS;Sbecomesopen: falsewith#1as its sole member, and#1cannot be linked into the new stack (rejected as belonging to another stack).
Net effect: a purely structural edit in the middle of the stack silently destroys the association between the merged layers and the layers that are still in flight.
Expected behavior
Either of:
- Insertion: a way to place a PR/branch at an arbitrary position of an existing stack, e.g.
gh stack link --after <pr>/--before <pr>/--position <n>, without tearing the stack down. - Lossless rebuild: allow merged PRs to be re-linked into a stack (or have
unstack+linkcarry them over), so the recovery procedure above at least preserves the full history of the stack.
Why it matters
Merged layers are exactly the part of a stack that documents why the remaining layers look the way they do. Keeping them attached is useful today when reading the stack, and it is what would let the web UI group a whole line of work — landed and in flight — under a single stack. Today, any mid-stack restructuring resets that grouping, so long-lived stacks progressively lose their own history.
Environment
gh stack version 0.1.0- Private repository, stacks enabled.
- Lenguaje dominante
- Go
- Estrellas
- 1.5k
- Forks
- 73
- Merge medio
- 1 d 8 h
- PR fusionados (30 d)
- 7
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de github/gh-stack
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 85/100
-
Dificultad 1/5 Menos de una hora Aptitud para principiantes 92/100
-
feature request topic: cli - general
Dificultad 2/5 1-3 horas Aptitud para principiantes 68/100
-
feature request topic: auto-merge
Dificultad 2/5 1-3 horas Aptitud para principiantes 68/100
-
bug topic: docs
Dificultad 1/5 Menos de una hora Aptitud para principiantes 68/100
Todos los issues de github/gh-stack
Issues similares
-
textual definition
Dificultad 1/5 Menos de una hora Aptitud para principiantes 90/100
geneontology/go-ontology#32653 ·
-
Dificultad 1/5 Menos de una hora Aptitud para principiantes 75/100
-
needs design
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
-
Priority/High ready-for-agent Severity/Major Type/Bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 70/100