[deep-report] Secret-redaction directory scan crashes with stack overflow, likely largest driver_exit failure source
Los mantenedores suelen responder en 1 día
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 2/5
- Tiempo estimado
- 1-3 horas
- Aptitud para principiantes
- 86/100
- Tipo de issue
- Error
- Claridad
- Bien especificado
- Estado de actividad
- Activo
- Stack tecnológico
- javascript
Línea de trabajo
Comienza con actions/setup/js/redact_secrets.cjs, especialmente con findFiles() y su rama de directorios recursiva. Lee redact_secrets_test.go y añade un caso de regresión para anidamiento profundo; después, verifica que el recorrido se complete sin un desbordamiento de la pila y mantenga el comportamiento de escaneo existente.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Description
actions/setup/js/redact_secrets.cjs's findFiles() (lines 19-46) recursively walks /tmp/gh-aw and ${RUNNER_TEMP}/gh-aw before every artifact upload, using plain JS recursion with no depth limit:
function findFiles(dir, extensions) {
...
} else if (entry.isDirectory()) {
results.push(...findFiles(fullPath, extensions)); // unbounded recursion depth
}
...
} catch (error) {
throw new Error(`${ERR_VALIDATION}: Failed to scan directory ${dir}: ${getErrorMessage(error)}`, { cause: error });
}
}
This crashed with Maximum call stack size exceeded while scanning /tmp/gh-aw/aw-mcp in two independent production runs on two different engines, both times after the agent itself had already completed its task successfully:
- run 36395018370 — "Daily Storify" (Codex engine)
- run 36377939174 — "Safe Output Health Monitor" (Claude engine)
Because this redaction step runs on every workflow before artifact upload, a Weekly Workflow Analysis fleet sample (100 runs, 2026-09-28) attributes this as likely the single largest contributor to driver_exit failures — 65% of the 31 failures in the sample were driver_exit (infra/CLI crash) rather than genuine agent errors, spread thin across ~30 different workflows (consistent with one shared infra bug, not per-workflow logic errors).
Expected Impact
Fixing this converts a meaningful share of fleet-wide driver_exit failures into successes — these are runs where the agent's actual work already succeeded but the run is marked failure purely because of this post-processing crash, wasting the failure-triage attention of every downstream analytics/audit workflow that reads run status.
Suggested Fix
Convert findFiles() from recursive to iterative (explicit stack/queue-based) directory traversal so scan depth is no longer bounded by the JS call stack. aw-mcp's internal cache/log structure likely produces enough directory nesting to exceed V8's default stack size; an iterative version has no such limit (or add an explicit max-depth cutoff with a warning if that's preferred over full traversal).
Suggested Agent
Any Go/JS-capable coding agent — this is a self-contained, single-file refactor with a clear existing unit-test file (redact_secrets_test.go) to extend with a deep-nesting regression case.
Estimated Effort
Medium (1-4 hours) — includes adding a regression test that reproduces stack overflow at depth (e.g. 10,000+ nested dirs) before the fix and passes after.
Data Source
DeepReport Intelligence Briefing 2026-09-28 (~18:00Z incremental cycle), sourced from discussion #63984 ("Weekly Workflow Analysis: 2026-09-28 sample"). Root cause independently verified by reading actions/setup/js/redact_secrets.cjs on main before filing.
Generated by 🔬 Deep Report · claude · agent · 198.5 AIC · ⌖ 8.81 AIC · ⊞ 13K · ◷
- expires on Sep 30, 2026, 10:48 AM UTC-08:00
- Lenguaje dominante
- Go
- Estrellas
- 5.2k
- Forks
- 547
- Merge medio
- 5 h 46 min
- PR fusionados (30 d)
- 658
Preparar el entorno
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de github/gh-aw
-
agentic-workflows
Dificultad 2/5 1-3 horas Aptitud para principiantes 68/100
Los mantenedores suelen responder en 1 día
-
agentic-workflows
Dificultad 2/5 1-3 horas Aptitud para principiantes 68/100
Los mantenedores suelen responder en 1 día
-
agentic-workflows
Dificultad 2/5 1-3 horas Aptitud para principiantes 68/100
Los mantenedores suelen responder en 1 día
-
automation code-quality cookie improvement quick-win task-mining
Dificultad 1/5 Menos de una hora Aptitud para principiantes 92/100
Los mantenedores suelen responder en 1 día
-
[deep-report] Fix stale pkg/workflow/js/ references in 4 skill files (3rd recurrence, count growing)Abiertoautomation code-quality cookie improvement quick-win task-mining
Dificultad 2/5 Menos de una hora Aptitud para principiantes 84/100
Los mantenedores suelen responder en 1 día
Todos los issues de github/gh-aw
Issues similares
-
bug needs-triage
Dificultad 2/5 1-3 horas Aptitud para principiantes 86/100
DataDog/dd-trace-go#5469 ·
Los mantenedores suelen responder en 1 día
-
bug tests
Dificultad 2/5 1-3 horas Aptitud para principiantes 88/100
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
l3montree-dev/devguard#3101 ·
Los mantenedores suelen responder en 1 día
-
area:*of bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
oapi-codegen/oapi-codegen#2593 ·
Los mantenedores suelen responder en 1 día
-
bug
Dificultad 1/5 Menos de una hora Aptitud para principiantes 85/100
DaoCloud/DaoCloud-docs#7432 ·
Los mantenedores suelen responder en 1 día