Missing parent trace activities (spans) when switching context between SDK and CLI

Abierto
  • ¿Algo no está bien?
#2,803 2 comentarios 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
68/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
csharp
Área
observability

Línea de trabajo

Start in dotnet/src/Telemetry.cs at RestoreTraceContext and trace how the created Activity becomes the parent for tool activities. Compare that behavior with the ActivitySource and github.copilot source details mentioned in the issue, then verify that the resulting trace tree preserves the external_tool parent and sampled child spans when switching between SDK and CLI.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

bug

We are using Copilot SDK for .NET and it seems like the thinking behind RestoreTraceContext (this) is not entirely correct. It creates a new Activity without the ActivitySource, which, indeed, prevents it from being sampled, but it still carries its own id (span id), which is then used as a parent span id for all children activities. So in the trace tree (In Grafana, for example) we see unparented spans from the tool implementations, which I think should be parented under external_tool spans from the Copilot CLI:

Image

the GET span (id d2c10abb001cb97a) has parent span id set to cabcf362cbf15a7a (which is nowhere to be found), where as external_tool span has an id of 2cd84acd8fb4e994. So, I think, the tree is:

external_tool (2cd84acd8fb4e994, from CLI)
 \ copilot.tool_handler (cabcf362cbf15a7a, from SDK) <--- "invisible activity"
    \ GET (d2c10abb001cb97a, from our tool code)

Why don't we just emit this span properly from ActivitySource (maybe matching SourceName/default github.copilot)?

I also think a similar problem exists in the CLI itself, because transitioning from SDK to CLI also leaves all "top-level" CLI spans unparented. CLI code doesn't seem to be open source, so I can't confirm, but my gut feeling is that a similar approach was used there in CLI, where it creates one span and doesn't attach it to a source that is being sampled/exported, so it never gets collected, leaving all other CLI spans unparented. 😞

Lenguaje dominante
Java
Estrellas
10.7k
Forks
1.5k
Sin PR fusionados en 30 d

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de github/copilot-sdk

Todos los issues de github/copilot-sdk

Issues similares

Más issues de Java

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.