Store Inbox snooze and pins on the server, with event-based snooze

Abierto
#3,106 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
5/5
Tiempo estimado
Más de una semana
Aptitud para principiantes
35/100
Tipo de issue
Nueva funcionalidad
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
typescript

Línea de trabajo

Start with inboxSnooze.ts and the Inbox implementation linked in #3036; trace how snooze and pin state affects the Inbox and navigation count. Then read the watch event handling for events such as pull_request.merged and deployment.succeeded. Done means snooze and pins are stored per viewer on the server and matching events can reopen snoozed items across devices.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

The dashboard Inbox (#3036) keeps snooze and pins in the browser only. Other devices and the nav count do not see them.

Current behavior

  • Snooze and pin state lives in the browser (inboxSnooze.ts). It is lost when you switch device, and it does not change the Inbox count in the nav.
  • Snooze only supports times.

Gap

  • Snoozed and pinned Review items should look the same on every device and in every count.
  • Many Junior asks only become actionable after an event, not at a time. Examples: a PR opens, a PR merges, a deployment finishes, or an Automation runs.

Proposal (raised by BYK): store snooze and pins per viewer on the server, and add "when" snooze conditions, in the spirit of Google Inbox's location-based snooze. Examples: "when automation X runs", "when this PR opens", "when this PR merges". Junior already delivers provider events such as pull_request.merged and deployment.succeeded to watches, so an event-based snooze could reopen the item when a matching event arrives.

Related: #3036, #3103.

via @BYK.

--

View Session [Sentry]

Lenguaje dominante
TypeScript
Estrellas
397
Forks
43
Merge medio
8 h 28 min
PR fusionados (30 d)
764

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de getsentry/junior

Todos los issues de getsentry/junior

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.