Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

explorer: a restored snapshot loses to a folder's running animation

Abierto
  • ¿Algo no está bien?
#305 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
35/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
zig
Área
desktop, testing

Línea de trabajo

Start with core/widgets/TreeWidget.zig (the branch's expanded and the _expanded data around lines 468 and 890) and plugins/workbench/src/files.zig (carryBack and the expander near line 1150), then find where setExplorerBranchOpen is called. Replay #293's property test with seed 0x6 to reproduce the failure. Done when the tree draws open or closed from the caller's value each frame, the expander reports toggles instead of writing back, and both the seed test and a new test that sets open state mid-close-animation pass.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

bug

Found by #293 (#280 step B1), whose property test replays a demo and seeks to random moments. With seed 0x6 it fails in the tour's explorer, on seeks to 46937, 13890 and 17830 ms: after a snapshot restore, the explorer's open folders aren't the ones the snapshot holds. The checked-in seed and nine others pass, so this shows up only when a seek lands during a folder's open or close animation.

Cause: open state lives in two places that copy each other

  • core.widgets.TreeWidget's branch keeps its own expanded, stored per widget as _expanded in dvui's data (core/widgets/TreeWidget.zig:468, :890). It eases toward the caller's value through an animation.
  • The workbench keeps the explorer's open folders on the host (setExplorerBranchOpen, the per-branch open state the snapshot captures and restores). Each frame it writes the branch's expanded back into that state (plugins/workbench/src/files.zig, carryBack and the expander around :1150).

So a restore that sets the host's open state while a branch's own animation is still running loses: the next frame copies the widget's in-flight value back over the restored one. Nothing is wrong with the snapshot or the player. The model has two writers.

Fix

Give the open state one owner. The tree should draw open or closed from the caller's value each frame, keeping only the animation's progress as its own state, and never write it back. Clicking the expander reports a toggle to the caller, which changes its state. Then a restore, or anything else that sets the open folders (a reveal-in-explorer, a demo keyframe), takes effect on the next frame with no race.

Test: #293's property test with seed 0x6 must pass, plus a focused integration test: start a folder's close animation, set the open state from outside, run frames, and check the branch ends open.

Part of #280.

🤖 Generated with Claude Code

Lenguaje dominante
Zig
Estrellas
1.5k
Forks
40
Merge medio
5 h 32 min
PR fusionados (30 d)
537

Preparar el entorno

Este proyecto no incluye contenedor de desarrollo, Dockerfile ni guía de contribución, así que la configuración corre por tu cuenta: empieza por su README y consulta nuestra guía para la primera contribución para los pasos generales.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de fizzyedit/fizzy

Todos los issues de fizzyedit/fizzy

Issues similares

Más issues de Desktop Dev

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.