Reduce filecoin-project org ownership

Abierto
  • ¿Algo no está bien?
#47 7 comentarios 1 reacción 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
5/5
Tiempo estimado
Más de una semana
Aptitud para principiantes
20/100
Tipo de issue
Nueva funcionalidad
Claridad
Bien especificado
Estado de actividad
Estancado
Stack tecnológico
github, typescript
Área
authorization, security

Línea de trabajo

Comienza con los PRs #60 y #61 de github-mgmt y la tarea restante vinculada al issue #65; el issue señala al equipo Stewards de github-mgmt y la configuración de la organización de GitHub como puntos de entrada. Revisa los cambios de permisos existentes y confirma que la propiedad, el acceso de push, las asignaciones de roles y las justificaciones de los nombres de usuario cumplen los criterios enumerados.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Done Criteria

  1. Reduce org ownership to only a couple of people since "org owners" have the ability to impact the github org as a whole and every repo in the org (docs). This includes destructive one-way operations like repo deletion. These people should:
    1. be active in the filecoin-project org because they are more likely to make informed decisions and
    2. collectively represent multiple independent companies/teams.
  2. Review/reduce who has push access to github-mgmt in the org, as that is an escalation path to "org ownership" as well. This translates to looking at the "github-mgmt stewards" team, since that team has push access to github-mgmt. This group should be:
    1. still small (5-8)
    2. active in the org because they are more likely to make informed decisions
    3. representative of multiple independent companies/teams
  3. Give the "github-mgmt Stewards" team "moderator" and "security manager" roles.
  4. There should be comments above each username that has "org owner like" permissions providing a justification.

Why Important

This is the lowest-hanging fruit to protect the filecoin-project org around overly generous permissions. We're obviously not seeking to restrict access to code itself, and this isn't about checking some box for "good OpSec". Some reasons we care about the OpSec here include:

  1. We want to reduce the ability of malicious actors' ability to introduce vulnerabilities/bugs when they compromise a member's account.
  2. We want to reduce the possibility that someone's account could be compromised and then destructive actions are taken like deleting repos.

Communication Channels

This issue and the connected PRs are intended to be the main communication channels.

Background

The filecoin-project org has accumulated a lot of permissions over the years. This was somewhat acceptable/mitigated in the past by Protocol Labs Inc being a single company. As Protocol Labs Inc moves to an innovation network of companies (related blog) and projects like Filecoin having more and more independent teams, we're overdue on cleaning up permissions and reevaluating past assumptions.

Notes

  1. I don't think giving moderator and security operator roles to a team can be one through github-mgmt itself. For example, I don't see any useful docs when searching Terraform's docs. It would need to be a one-time action through the GitHub UI rather than through github-mgmt.
  2. For reference, a similar campaign was done in IPFS earlier in 2024 per https://github.com/ipfs/ipfs/issues/511
  3. I went through all permissions listed in github org role docs and then listed how I think they could/should be handled (see the collapsed table at the bottom of https://github.com/ipfs/ipfs/issues/511#issuecomment-1947577416).
## Tasks
- [x] Temporarily escalate @BigLep permissions so can view the [audit log](https://docs.github.com/en/organizations/keeping-your-organization-secure/managing-security-settings-for-your-organization/reviewing-the-audit-log-for-your-organization) and give the moderator and security manager permissions to the newly created teams in https://github.com/filecoin-project/github-mgmt/pull/60
- [x] PR for proposing/doing the corresponding permissions changes including the related communication: https://github.com/filecoin-project/github-mgmt/pull/61
- [x] Give the "moderators" team moderator permissions.
- [x] Give the "security-managers" team security manager permissions
- [ ] ~Revoke @BigLep's escalated permissions~ Per #61, he is keeping permissions through 2024-12-31.
- [ ] https://github.com/filecoin-project/github-mgmt/issues/65
Lenguaje dominante
TypeScript
Estrellas
2
Forks
25
Merge medio
2 d 12 h
PR fusionados (30 d)
4

Preparar el entorno

  • Sin Dockerfile ni archivo de Docker Compose
  • Tiene una plantilla de pull request
  • Sin guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de filecoin-project/github-mgmt

Todos los issues de filecoin-project/github-mgmt

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.