feat: flag internet-facing load balancers with no WAF

Abierto
  • ¿Algo no está bien?
#128 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
58/100
Tipo de issue
Nueva funcionalidad
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
aws, rust
Área
cloud, security

Línea de trabajo

Read docs/recipes/README.md and docs/recipes/add-a-finding.md, then inspect src/app/findings.rs and src/models/elb.rs. Follow the a_failed_tag_lookup_is_not_reported_as_unowned pattern and check how WAF fetch status and associated resources are represented. Done means the predicate and rule tests cover the four cases, the roadmap and minor changeset are updated, and the requested Rust checks pass; this issue is blocked by #127.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

size: S

Why

Every public Fells endpoint goes through one ALB. If its WAF association is ever dropped, the geo allow-list and rate limit silently stop applying.

Follow docs/recipes/add-a-finding.md.

Steps

  1. Add the web ACLs to FindingContext.
  2. Rule load_balancer_without_waf (Hygiene, High): an application load balancer with scheme internet-facing whose ARN is not in any ACL's associated resources.
  3. Only judge when the WAF fetch succeeded. If the WAF status is not OK, the rule must report nothing (see a_failed_tag_lookup_is_not_reported_as_unowned for the pattern).
  4. Tests: covered ALB is quiet, uncovered ALB fires, internal ALB is quiet, failed WAF fetch is quiet.

Where to look

  • src/app/findings.rs
  • src/models/elb.rs

Done when

  • Predicate on the model with unit tests (one firing case, one quiet case)
  • Rule added to FINDING_RULES with tests in src/app/findings.rs
  • docs/findings-roadmap.md lists the rule under Current Findings
  • Changeset added (minor)
  • cargo fmt --all, cargo clippy --all-targets -- -D warnings, and cargo test --all pass, with output pasted in the PR

Check against AWS

Optional. Unit tests are enough for this issue.

Blocked by

#127. Start this after that is merged.

Size: S. Read docs/recipes/README.md before starting.

Lenguaje dominante
Rust
Estrellas
2
Forks
0
Merge medio
4 h 8 min
PR fusionados (30 d)
8

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de fells-code/seamless-glance

Todos los issues de fells-code/seamless-glance

Issues similares

Más issues de Rust

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.