Windows ARM64 package: import library does not match the README or the renamed DLL

Abierto
#4,997 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
58/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
c, cmake
Área
build-system

Línea de trabajo

Start with lib/dll/example/build_package.bat and the package README, then inspect the Windows ARM64 CMake target settings that determine the DLL and import library names. Verify which packaged names let Visual C++ link and load the DLL correctly; done means the package contains the promised import library and its name matches the DLL it loads.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

The win-arm64 package is built with CMake, and lib/dll/example/build_package.bat copies:

  • zstd.dll as dll\libzstd.dll
  • zstd.lib as dll\zstd.lib

The package README promises dll\libzstd.lib as the import library for Visual C++, so that file is missing, like in #4027 for the MSYS2 packages (fixed there by #4992).

There is likely a second problem: an import library records the name of the DLL it was built for. Linking with zstd.lib should produce an executable that loads zstd.dll, which this package renames to libzstd.dll. I could not test this on Windows.

This package has not shipped yet (v1.5.7 only has win32 and win64), so it can be fixed before its first release. Two options: keep the DLL as zstd.dll in this package and ship the import library as dll\libzstd.lib, or build the DLL as libzstd.dll so that its import library matches the package.

Related: #4395.

Lenguaje dominante
C
Estrellas
28.1k
Forks
2.7k
Métricas de merge de PR
Sin PR fusionados en 30 d

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de facebook/zstd

Todos los issues de facebook/zstd

Issues similares

Más issues de C

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.