False `bad-override` on SQLModel `__tablename__ = "..."` ("must both be descriptors")

Abierto
#5,699 1 comentario 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
48/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
python, rust, sqlalchemy
Área
devtools, testing

Línea de trabajo

Start by locating Pyrefly's bad-override diagnostic and the logic that compares class member descriptors; the issue does not name source files or tests. Reproduce with the shown SQLModel example using Python 3.13 and SQLModel 0.0.38, then check the existing override tests. Done when a plain string and a declared_attr directive override are accepted without regressing other override checks.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

question sqlalchemy
Describe the Bug

Setting __tablename__ to a string on a SQLModel table, which is how SQLModel's docs name a table, is reported as bad-override:

from sqlmodel import Field, SQLModel


class Hero(SQLModel, table=True):
    __tablename__ = "heroes"
    id: int | None = Field(default=None, primary_key=True)
ERROR Class member `Hero.__tablename__` overrides parent class `SQLModel` in an inconsistent manner [bad-override]
 --> repro.py:5:5
  `Hero.__tablename__` and `SQLModel.__tablename__` must both be descriptors

SQLModel declares __tablename__ as a @declared_attr classmethod-style descriptor, but SQLAlchemy and SQLModel both accept a plain string in a subclass at runtime. Writing the override as a descriptor does not help either:

from sqlalchemy.orm import declared_attr

class Hero(SQLModel, table=True):
    @declared_attr.directive
    def __tablename__(cls) -> str:
        return "heroes"

This still reports the same error, so there is no spelling that type-checks. In a codebase with many tables, the result is one error per model.

Expected: a plain str (or a declared_attr directive) is accepted as an override of declared_attr __tablename__. Possibly related: #891, #2561.

Versions: pyrefly 1.3.1, sqlmodel 0.0.38, SQLAlchemy 2.0.49, Python 3.13. The config is just python-version = "3.13" (default preset). The basic preset does not report it.

Sandbox Link

No response (needs sqlmodel installed)

(Only applicable for extension issues) IDE Information

No response

Lenguaje dominante
Rust
Estrellas
7.2k
Forks
578
Métricas de merge de PR
Sin PR fusionados en 30 d

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de facebook/pyrefly

Todos los issues de facebook/pyrefly

Issues similares

Más issues de Rust

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.