hardcoded paths, and hardcoded filenames
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 5/5
- Tiempo estimado
- Más de una semana
- Aptitud para principiantes
- 20/100
Línea de trabajo
Empieza inspeccionando cron_wrapper, virtual_servers, la ruta pythonvenv/python37 y los archivos de configuración .f5creds y load-balancer. Traza cómo se seleccionan las rutas, los nombres de archivo, las credenciales y F5_HTTPS; después, comprueba si se admiten sobrescrituras desde la línea de comandos o varios load balancers. Se considerará terminado cuando exista un enfoque de configuración definido que evite las suposiciones hardcoded indicadas y preserve el comportamiento necesario de HTTP challenge y HTTPS deployment.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
cron_wrapper is not executable in the repo. That should be changed.
paths are hardcoded which won't work for most users. Perhaps something like:
- cd $HOME/lets-encrypt-python
Also, I don't have a
pythonvenv/python37/bin/activate
what should that contain?
This code breaks our setup. I have multipe file sets.
- {loadbalancer} - contains all my setting including host, user, pass, http, https
- {loadbalancer}.cfg - DOMAINS_TXT="${BASEDIR}/{load balancer}.dom"
- {loadbalancer}.dom - all the san certs each set on one line
Having the authentication in the environment meant that I could talk to different load-balancers, potentially with different credentials all in one directory. the ONE .f5creds that can't seem to be overridden breaks that.
The file "virtual_servers" also breaks this setup, looks hardcoded, and can't be overridden on the command line. This file assumes that the virtual server name for a given hostname is the same on each load balancer, which is often not a valid assumption. It also require adding each domain on a san cert to the lookup table. This might be useful in some situations, but not for me at the moment as I'm only testing on one vs per lb.
Eventually it would be nice to be able to deploy the validation changes on multiple load balancers, test, and then remove from multiple load balancers in the case were a host uses GTM/DNS load balancing or just has multiple IPs in DNS.
This seems to remove the F5_HTTPS handling. The Let's Encrypt challenge is over http, which should be a separate vip from the one where the cert should be installed in the end. We'll want a F5_HTTPS if eventually we want to add the created ssl profile to a vip, as it won't be the same vip.
- Lenguaje dominante
- Shell
- Estrellas
- 50
- Forks
- 12
- Métricas de merge de PR
- Sin PR fusionados en 30 d
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de f5devcentral/lets-encrypt-python
-
Dificultad 4/5 3-5 días Aptitud para principiantes 25/100
-
Cert Chain Exists Abierto
f5devcentral/lets-encrypt-python#2 · 2 comentarios · 1 asignado ·
Todos los issues de f5devcentral/lets-encrypt-python
Issues similares
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 70/100
-
Dificultad 1/5 Menos de una hora Aptitud para principiantes 85/100
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
-
bug easy help wanted
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
lacs-project/sysknife#503 ·
-
help wanted kind/documentation
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
liquidmetal-dev/flintlock#1239 ·