'Robot Name' false positive tests

Abierto
#943 7 comentarios 0 reacciones 1 asignado Ver en GitHub

Los mantenedores suelen responder en 1 día

@SleeplessByte ya está trabajando en esto.

Desde el 29/7/2024.

Evaluación

Este issue todavía no se ha evaluado.

Descripción

Issue

The top-ranked solutions for 'Robot Name' in Typescript are currently passing all unit tests even though (and primarily because) they are generating names that do not conform to the problem specification.

While the tests interpret these names as 'unique' because they do not exist within their respective Sets, repeating the regex check for each 'new name' function invocation exposes these strings as invalid robot names.

2nd Solution
Screenshot 2022-02-14 at 1 38 19 am

3rd Solution
Screenshot 2022-02-14 at 1 33 08 am

Notes

  • This issue may need to be addressed in other tracks as well.
  • Implementing the regex check for each newly generated name adds about 10 seconds to even the most optimal solutions when checking all possible permutations. There may be a more performant approach for strengthening these tests.

<200ms solution
Screenshot 2022-02-14 at 1 42 20 am

Quick Links

https://github.com/exercism/typescript/blob/main/exercises/practice/robot-name/.docs/instructions.md
https://github.com/exercism/typescript/blob/main/exercises/practice/robot-name/robot-name.test.ts
https://exercism.org/tracks/typescript/exercises/robot-name

Lenguaje dominante
TypeScript
Estrellas
165
Forks
174
Merge medio
41 min
PR fusionados (30 d)
1

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de exercism/typescript

Todos los issues de exercism/typescript

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.