Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

StartClient leaks a PostgreSQL connection pool on every instance connect

Abierto
  • ¿Algo no está bien?
#215 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
Medio día
Aptitud para principiantes
45/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
go, postgresql
Área
backend, databases

Línea de trabajo

Start in pkg/whatsmeow/service/whatsmeow.go at the sqlstore.New call inside StartClient, and compare it with the pool settings in pkg/config/config.go, which only apply to the CreateAuthDB and CreateUsersDB handles. Decide whether to share one container across instances or keep one per instance and close it on disconnect or restart. Done when repeated connects and reconnects no longer grow the idle connection count on the auth database.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Summary

StartClient creates a new sqlstore.Container on every call and never closes the previous one, so each instance connection (and each auto-reconnect) leaks a full database/sql connection pool. On a busy server this exhausts PostgreSQL max_connections and the instances stop being able to connect at all.

Reproduced on tag 0.7.2; the code is the same on main.

The leak

pkg/whatsmeow/service/whatsmeow.go, inside StartClient:

container, err = sqlstore.New(context.Background(), "postgres", w.config.PostgresAuthDB, nil)

Two things combine here:

  1. sqlstore.New opens its own *sql.DB. The pool limits set in pkg/config/config.go (SetMaxOpenConns(25), SetMaxIdleConns(5), SetConnMaxIdleTime(1 * time.Minute)) apply to the handles returned by CreateAuthDB/CreateUsersDB, not to this one.
  2. There is no container.Close() anywhere in the file — only the client is kept (in clientPointer). The container goes out of scope, but Go's GC does not close a *sql.DB's connections; they stay open until an explicit Close().

StartClient runs on startup (CONNECT_ON_STARTUP), on every /instance/connect, and on every automatic reconnect — so an instance that keeps dropping (logged out from phone, QR expired) leaks fastest.

Evidence from production

Measured on a server with 22 connected instances out of 33:

66 connections to the auth database — 100% idle, 0 active
oldest: opened 32m20s ago, idle 32m19s     ← used once, then abandoned
growth: ~30 connections/hour on top of the 44 the startup opens

The per-connection pattern is a staircase — one group per connection attempt, each idle since the moment it was created. From a fresh start it reaches a 300-connection threshold in about 9 hours.

Because the pools are never reused, terminating the idle connections is safe and reclaims them immediately (verified: 66 → 40, all instances stayed connected, traffic continued within 5 seconds, no database errors) — but that is a workaround, not a fix.

Suggestion

Either create the container once and share it across instances (the DSN is the same for all of them), or keep a reference per instance and Close() it when the instance disconnects or is restarted.

Lenguaje dominante
Go
Estrellas
929
Forks
499
Merge medio
5 min
PR fusionados (30 d)
1

Preparar el entorno

  • Incluye un Dockerfile o un archivo de Docker Compose
  • Tiene una plantilla de pull request
  • Sin guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de evolution-foundation/evolution-go

Todos los issues de evolution-foundation/evolution-go

Issues similares

Más issues de Go

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.