Project fails to configure in cmake since i updated emsdk to 6.0.6

Abierto
  • ¿Algo no está bien?
#27,520 6 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
48/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Tranquilo
Stack tecnológico
cmake, wasm
Área
build-system

Línea de trabajo

Empieza con FindThreads.cmake de CMake y las llamadas de third_party/or_tools/cmake/system_deps.cmake:17 y third_party/or_tools/CMakeLists.txt:450. Compara la configuración con emsdk 6.0.4 y 6.0.6, con pthreads deshabilitado, y comprueba si Abseil muestra el mismo fallo. Se considera terminado cuando los proyectos afectados se configuren correctamente sin threads habilitados.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Hello,

My project depends on or_tools third party project, which has those lines in cmake:

set(CMAKE_THREAD_PREFER_PTHREAD TRUE)
set(THREAD_PREFER_PTHREAD_FLAG TRUE)
find_package(Threads REQUIRED)

The thing is I do not need threads (threads aren't enabled in my root CMakeLists.txt).
So I absolutely have no idea how this was working before. It was just working about 2 years so I didn't ask questions...

But now it fails:

CMake Error at C:/Program Files/CMake/share/cmake-3.30/Modules/FindPackageHandleStandardArgs.cmake:233 (message):
Could NOT find Threads (missing: Threads_FOUND)
Call Stack (most recent call first):
C:/Program Files/CMake/share/cmake-3.30/Modules/FindPackageHandleStandardArgs.cmake:603 (_FPHSA_FAILURE_MESSAGE)
C:/Program Files/CMake/share/cmake-3.30/Modules/FindThreads.cmake:226 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
third_party/or_tools/cmake/system_deps.cmake:17 (find_package)
third_party/or_tools/CMakeLists.txt:450 (include)

Yesterday everything was fine. Since yesterday i just upgraded Python from 3.10.0 to 3.10.11 and emsdk to 6.0.6 (do not remember exactly which version was before, probably 6.0.4).

I doubt Python broke Threads setup in cmake.

Is anything were changed in emsdk regarding Threads setup with disabled pthreads recently ?

P.S. It's not just or_tools. Tried to disable Threads in or_tools:
if (NOT EMSCRIPTEN)
find_package(Threads REQUIRED)
endif()

But it fails in many other projects. For example Abseil also fails with the same error.

Lenguaje dominante
C++
Estrellas
27.8k
Forks
3.6k
Merge medio
1 d 3 h
PR fusionados (30 d)
179

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de emscripten-core/emscripten

Todos los issues de emscripten-core/emscripten

Issues similares

Más issues de C++

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.