Feature request: live: allow pausing the notify triggers during bulk writes (e.g. pglite-sync applies) and refresh once on resume
Los mantenedores suelen responder en 1 día
@tdrz ya está trabajando en esto.
Desde el 2/11/2026.
Evaluación
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Aptitud para principiantes
- 25/100
- Tipo de issue
- Nueva funcionalidad
- Claridad
- Bastante claro
- Estado de actividad
- Activo
- Stack tecnológico
- postgresql, typescript
- Área
- databases
Línea de trabajo
Start with addNotifyTriggersToTables() in packages/pglite/src/live/index.ts, where the generated _notify_ trigger function body is created, and read the setup comment about triggers being added but never removed. Before any code, the open question is design: whether a GUC check, live.pause()/live.resume(), or both should be adopted, which the maintainers have not yet answered. Done means a maintainer-agreed design and tests showing that a bulk write with notifications suspended emits no notify, with one refresh on resume.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
This was prepared by my AI tools (GLM 5.3, refined by Claude Fable 5.1). Applying it solved my performance issue but I must admit I could not have done this myself. So make of it what you want. I hope it helps others but also that I'm not spamming you with garbage.
Summary
The live extension's notify triggers fire unconditionally, so during bulk writes — in particular @electric-sql/pglite-sync applying a shape snapshot — every mounted live query re-runs back-to-back for the entire duration of the write. A supported way to pause notifications (and refresh once on resume) would remove this.
Current behaviour
addNotifyTriggersToTables() in packages/pglite/src/live/index.ts creates, per table a live query depends on, one function _notify_<schema_oid>_<table_oid>() that does PERFORM pg_notify('table_change__…', ''), attached as an AFTER INSERT OR UPDATE OR DELETE … FOR EACH STATEMENT trigger. There is no condition under which it stays silent. (As the comment in setup notes, the triggers are only ever added, never removed; tableNotifyTriggersAdded guarantees exactly one function per table.)
pglite-sync applies each batch in a transaction with SET LOCAL electric.syncing = true. Postgres de-duplicates identical notifications within a transaction, so after each commit every table written in that batch notifies once, and every live query reading any of those tables calls refresh().
refresh() is wrapped in debounceMutex, so a single query never has more than one run in flight plus one pending. That bounds it per query — but the net effect is that every mounted live query re-runs continuously for as long as the sync is applying, each run a full query through the same serialized execution queue the applies themselves use.
Impact
Our app: ~60 shapes, a navigation tree with up to a few hundred mounted live queries, a few hundred thousand rows on first sync or on a shape 409 re-snapshot. Unmodified, the notify traffic roughly doubled initial sync time, drove memory up noticeably and starved interactive reads until the sync settled.
Workaround we use
After boot (and periodically, because the functions are created lazily when a table gets its first live query) we rewrite the generated function bodies:
CREATE OR REPLACE FUNCTION "_notify_<s>_<t>"() RETURNS trigger AS $$
BEGIN
IF COALESCE(NULLIF(current_setting('electric.syncing', true), ''), 'false')::boolean THEN
RETURN NULL;
END IF;
PERFORM pg_notify('table_change__<s>__<t>', '');
RETURN NULL;
END $$ LANGUAGE plpgsql;
and when the sync reports up-to-date we fire one pg_notify per live channel so queries that were mounted during the sync pick up the applied data. It works, but it reaches into generated internals, couples live to pglite-sync's private GUC, and the settle round is easy to get wrong (without it, queries mounted mid-sync show empty results until the next real write).
Proposal
Keep live generic, but give bulk writers a supported way to suspend notifications:
- A GUC checked by the generated trigger function, e.g.
pglite.live_notify(default on). Any bulk writer canSET LOCAL pglite.live_notify = offinside its transaction — pglite-sync applies, imports,COPY-style loads. Since there is exactly one generated function per table, this is a one-line change inaddNotifyTriggersToTables()with no new bookkeeping. live.pause()/live.resume()on the namespace (or a transaction-scoped helper), whereresume()issues one notification per table written while paused, so live queries mounted mid-pause are refreshed exactly once instead of never.- pglite-sync uses (1) in its apply transaction and calls (2) when a batch ends up-to-date.
(1) alone removes the amplification; (2) is what makes the home-grown settle round unnecessary.
Happy to open a PR for (1) and the pglite-sync side if this direction is acceptable.
Environment
@electric-sql/pglite0.5.14,@electric-sql/pglite-sync0.6.15,@electric-sql/client1.5.28- PGlite in a web worker with IndexedDB persistence, Chrome on Linux
- Lenguaje dominante
- TypeScript
- Estrellas
- 16.3k
- Forks
- 474
- Merge medio
- 23 h 53 min
- PR fusionados (30 d)
- 53
Preparar el entorno
Este proyecto no incluye contenedor de desarrollo, Dockerfile ni guía de contribución, así que la configuración corre por tu cuenta: empieza por su README y consulta nuestra guía para la primera contribución para los pasos generales.
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de electric-sql/pglite
-
Feature request: Nitro 3 support (`unwasm` export condition)Quizá libre de nuevo Un pull request para esta issue se cerró sin fusionarse. Abierto
Dificultad 1/5 Menos de una hora Aptitud para principiantes 85/100
electric-sql/pglite#1120 · 16 comentarios ·
Los mantenedores suelen responder en 1 día
-
Dificultad 5/5 Más de una semana Aptitud para principiantes 25/100
electric-sql/pglite#1200 · 1 comentario ·
Los mantenedores suelen responder en 1 día
-
Dificultad 4/5 3-5 días Aptitud para principiantes 54/100
electric-sql/pglite#1192 ·
Los mantenedores suelen responder en 1 día
-
[BUG]: syncToFs() resolves immediately, without syncing, when another sync is already queuedPosiblemente ocupada @PrabalParihar la tomó hace 11 días. Abiertobug
Dificultad 3/5 1-2 días Aptitud para principiantes 35/100
electric-sql/pglite#1191 ·
Los mantenedores suelen responder en 1 día
-
pglite-socket: handleData copies the whole buffer for every chunk (quadratic time for large messages)Posiblemente ocupada @benclmnt la tomó hace 10 días. Abierto
Dificultad 3/5 1-2 días Aptitud para principiantes 62/100
electric-sql/pglite#1181 · 3 comentarios ·
Los mantenedores suelen responder en 1 día
Todos los issues de electric-sql/pglite
Issues similares
-
area:cli area:security bug priority:medium
Dificultad 2/5 1-3 horas Aptitud para principiantes 82/100
rtk-ai/rtk#5127 · 1 comentario ·
Los mantenedores suelen responder en 1 día
-
"code source" and "numerique.gouv" links: "new window" mention duplicated in the accessible nameAbiertoaccessibility
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
numerique-gouv/lasuite-landingpage#315 ·
Los mantenedores suelen responder en 1 día
-
needs:triage
Dificultad 1/5 Menos de una hora Aptitud para principiantes 92/100
Los mantenedores suelen responder en 1 día
-
Dificultad 1/5 Menos de una hora Aptitud para principiantes 72/100
HyeokjaeChoi/vaultme#585 ·
Los mantenedores suelen responder en 1 día
-
enhancement priority/P2
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
beettlle/pi-smart-router#200 ·