An admin with two passkeys cannot serve shared Exit, Engine or model grants

Abierto
  • ¿Algo no está bien?
#485 1 comentario 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
48/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
rust
Área
authentication, backend

Línea de trabajo

Start with active_passkey_principals in auth.rs and the four authorization loops in gateway_home_system.rs at lines 3936, 4023, 4069, and 4379. Review the existing Exit test, then add coverage for each grant path with duplicate passkeys and for two different principals holding the same grant ID. Done means duplicate records for one principal are handled once while ambiguity between distinct principals is still refused.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

What happens

An admin can add a second passkey to the same account, for example a security key (#338, #452). After that, Runtime refuses a contact's approved Browser Exit grant from this Home with "Exit grant ownership is ambiguous". The same grant served while the admin had one passkey.

Cause (source reading at 460b1888d)

active_passkey_principals (auth.rs) returns one record per active passkey, and an added passkey keeps the same principal ID and root (complete_passkey_add). authorize_home_service_exit, authorize_home_engine_preparation_cancellation, authorize_home_service_engine and authorize_home_service_model (gateway_home_system.rs 3936, 4023, 4069 and 4379) read the principal's service requests once per record. They find the same grant twice and stop at their ambiguity check, so Engine preparation cancellation is refused as well.

Evidence

A throwaway test at 460b1888d covers Exit only. It passes with one passkey. After a second active passkey record is added for the same principal, it fails with Exit grant ownership is ambiguous. The test builds the second record by hand with the fields the add path writes; it does not run a WebAuthn ceremony. Engine and model use the same loop, so they are expected to fail the same way, but those were not run.

Fix direction

Visit each principal ID once in the four loops and keep the ambiguity check for two different principals. Leave active_passkey_principals unchanged. Add one test per path that adds a second passkey, and keep a test where two different principals hold the same grant ID and are refused.

Release disposition

Milestone 0.8.0. The fix is prepared as its own commit for the same train head as the #483 containment, with its own review. If it is not reviewed and through the gates in time, it becomes a go/no-go item.

Not yet checked

An installed Home with two real passkeys, and whether alpha.24 already includes the add-passkey feature.

Lenguaje dominante
Rust
Estrellas
6
Forks
2
Merge medio
1 d 3 h
PR fusionados (30 d)
42

Preparar el entorno

Este proyecto no incluye contenedor de desarrollo, Dockerfile ni guía de contribución, así que la configuración corre por tu cuenta: empieza por su README y consulta nuestra guía para la primera contribución para los pasos generales.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de elastos/elastos-runtime

Todos los issues de elastos/elastos-runtime

Issues similares

Más issues de Rust

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.