Filter level: a reference date before 1 AD looks like an input error

Abierto
#358 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
78/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
javascript, react

Línea de trabajo

Start with packages/pivotkit-react/src/filter-level.jsx around dayWhole, aria-invalid, and the quick-anchor-date-hint line, then inspect dateInputValue in packages/pivotkit-react/src/menu-ops.js. Add English and German neutral guidance for an applied date the field cannot display, and cover the field with a browser or render test. Done when that case omits aria-invalid, shows the guidance, and existing behavior for dates from 1 AD remains intact.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

idea

Follow-up from the review of #357 (#351).

An <input type="date"> cannot hold a year before 1 AD. When a view's quick choice counts from a reference date before 1 AD (pivotkit-core accepts it, for example from a loaded view), the Filter level shows the date field empty, marks it aria-invalid and shows "Enter a whole date; the ranges still count from 5 BC." That reads as if the user made a mistake. The date that applies is fine; the field simply cannot show it.

Where: the reference date's field in filter-level.jsx (dayWhole, aria-invalid, the quick-anchor-date-hint line) and dateInputValue in menu-ops.js.

Fix: when the field is empty only because the applied date cannot be shown, leave out aria-invalid and show a neutral line instead ("Counts from 5 BC, a date this field cannot show; enter a date to change it."), in English and German. Add a browser or render test that covers the field (none touches quick-anchor-date yet).

Not affected: dates from 1 AD on, which is all real data I know of. Typing a whole date still replaces such a reference date.

Lenguaje dominante
JavaScript
Estrellas
1
Forks
1
Merge medio
3 h 34 min
PR fusionados (30 d)
213

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de eizedev/pivotkit

Todos los issues de eizedev/pivotkit

Issues similares

Más issues de JavaScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.