fix(web): make the hero tilt e2e test settle on the flat transform

Abierto
  • ¿Algo no está bien?
#464 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
Medio día
Aptitud para principiantes
62/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
playwright, react, typescript
Área
testing

Línea de trabajo

Start at e2e/data-flow.spec.ts around lines 254-288 (the "tilt" test) and read how flat is captured versus how drawn is polled; the angles already read [0, 0], so the mismatch is in the perspective term of the transform. Reproduce with the guarded runner, --repeat-each 20, on that spec, and check whether layout, viewport or font load changes the stage size between the read of flat and the assertion; the hero stage component is the place to look if the cause is there. Done means 20 consecutive passing runs through the guarded runner with the 5 degree assertion still intact.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

area: web bug priority: P2 size: S

Context

e2e/data-flow.spec.ts:254 "the stage tilts toward a mouse pointer, never past 5 degrees, and not while paused" failed in CI on #457 (run 43707487703, head 7309a34), and passed on #451 and #453 the same hour with no related change, so it is flaky. Found in the #457 review.

> 288 |     await expect.poll(drawn).toBe(flat);
Expected: "matrix3d(1, 0, 0, 0, 0, 1, 0, 0, 0, 0, 1, -0.000626338, 0, 0, 0, 1)"
Received: "matrix3d(1, 0, 0, 0, 0, 1, 0, 0, 0, 0, 1, -0.000714286, 0, 0, 0, 1)"
Timeout 5000ms exceeded while waiting on the predicate

The angles poll at line 287 already returned [0, 0], but the drawn matrix kept a different perspective term (-1/1400 against -1/1597), so the expected flat value depends on something other than the tilt, probably the stage size or perspective at the moment flat was read.

End-to-end tests (Chromium) is a required check on main, so a flaky failure blocks merges.

Plan

  1. Find what changes the perspective term between reading flat and the assertion (layout, viewport, or font load).
  2. Make the test compare what it means to compare (no rotation) rather than the whole matrix, or read flat after the stage settles. Do not loosen the 5 degree assertion.

Acceptance criteria

  • The spec passes 20 runs in a row through the guarded runner (--repeat-each 20).
  • Playwright e2e: this spec is the coverage.

Files and areas

e2e/data-flow.spec.ts, and the hero stage component if the cause is there. Non-goals: the header bug in #460.

Model: anthropic/claude-opus-5-5 | Reasoning effort: unknown

Lenguaje dominante
TypeScript
Estrellas
1
Forks
1
Merge medio
6 h 56 min
PR fusionados (30 d)
136

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de eddiejaoude/StackDash

Todos los issues de eddiejaoude/StackDash

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.