fix(alerts): show a delete failure after its confirmation dialog is dismissed

Abierto
  • ¿Algo no está bien?
#369 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
62/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
nextjs, playwright, react, typescript
Área
frontend

Línea de trabajo

Start in src/components/alerts/confirm-delete.tsx, around the DialogError render (line 87) and the DialogCloseButton cancel (line 93), and read the #367 fix in src/components/connections/connection-controls.tsx (ConfirmDialog, ConfirmForm) to see how the form reports through a ref whether it is still mounted in an open dialog. Then read e2e/connections.spec.ts for the page.route hold-dismiss-release pattern before editing e2e/alert-rules.spec.ts. Done looks like: failure shown beside the Delete button in an assertive live region after dismissal, shown in the reopened dialog when applicable, still in-dialog only while open, with the new e2e case passing under safe-e2e.sh plus typecheck and lint.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

area: alerts bug priority: P2 size: XS

Context

The same defect as #367, in the alerts delete confirmation. ConfirmDeleteForm in src/components/alerts/confirm-delete.tsx shows a failure only through DialogError inside the dialog (line 87). Its Cancel button (DialogCloseButton, line 93) stays enabled while the confirm button reads "Deleting", and Escape closes the dialog as well. The form stays mounted, so the action finishes, and a failure that arrives after the dialog closed lands in the hidden dialog. Nothing is shown or announced.

Found by the Fable review of #368 (review round 1), which fixed the connections dialogs only.

Plan

  • Follow the #367 fix in src/components/connections/connection-controls.tsx (ConfirmDialog and ConfirmForm). The confirmation reports whether it is still mounted in an open dialog, read through a ref on its form. When it is not, ConfirmDelete shows the failure beside its button, and also passes it to the open dialog's DialogError when a reopen replaced the confirmation, because the page behind an open modal is inert.
  • Cover it in e2e/alert-rules.spec.ts the way e2e/connections.spec.ts covers #367: hold the server action with page.route, dismiss, release, and expect the failure beside the button. Include the reopened case.

Acceptance criteria

  • Dismissing an alert rule or budget delete dialog while it reads "Deleting", then the delete failing, shows the failure beside the Delete button in an assertive live region.
  • Reopening the dialog before the failure arrives shows it in the reopened dialog, focused and announced, and beside the button once the dialog closes.
  • A failure while the dialog is open still shows only inside it (expectFailureInDialog checks this).
  • Playwright e2e coverage added for the dismissed case.

Files and areas

  • src/components/alerts/confirm-delete.tsx
  • e2e/alert-rules.spec.ts
  • Non-goals: the connections dialogs (#367), projects and public metrics dialogs.

Verification

  • safe-e2e.sh on e2e/alert-rules.spec.ts
  • npm run typecheck, npm run lint

Model: anthropic/claude-opus-5-5 | Reasoning effort: high

Lenguaje dominante
TypeScript
Estrellas
1
Forks
1
Merge medio
6 h 56 min
PR fusionados (30 d)
136

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de eddiejaoude/StackDash

Todos los issues de eddiejaoude/StackDash

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.