Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

[GTK] Remove forceResize() from getClientArea on Wayland and the org.eclipse.swt.resizeOnGetClientArea property

Abierto
  • ¿Algo no está bien?
#3,717 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
35/100
Tipo de issue
Refactorización
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
java
Área
desktop

Línea de trabajo

Start in the GTK Scrollable, Composite, Table and Tree classes, where RESIZE_ON_GETCLIENTAREA guards the forceResize() call in getClientAreaInPixels(). Read the history of commit ff04b1368c and Bug 484682 before changing anything. Done means the constant, the four guarded calls and the org.eclipse.swt.resizeOnGetClientArea property are removed, and the PDE API Baseline dialog and JDT Pull Down wizard still render correctly on Wayland.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

On GTK, Scrollable, Composite, Table and Tree call forceResize() in getClientAreaInPixels() only when RESIZE_ON_GETCLIENTAREA is set:

static final boolean RESIZE_ON_GETCLIENTAREA = OS.isWayland() || Boolean.getBoolean("org.eclipse.swt.resizeOnGetClientArea");

Bug 484682 removed the call in 2020 because a getter changing widget state led to a stack overflow.
The -Dorg.eclipse.swt.resizeOnGetClientArea=true property was added as an escape hatch to the old behavior, and nothing in the Eclipse projects sets it.
Shortly after, the call was restored for Wayland only (ff04b1368c, "temporary workaround"), because the PDE API Baseline edit dialog and the JDT Pull Down wizard rendered wrongly on GTK 3.24.14 under Wayland.
The follow-up, Bug 563191, was never worked on.

A check on GTK 3.24.52 under a headless Wayland compositor found no remaining need for it.
JFace wizard dialogs modeled on the two reported ones (a checkbox tree page, a checkbox table sizing its columns from getClientArea()) and a ScrolledComposite sized from getClientArea() produced identical bounds, client areas and column widths for all 106 controls with and without the forced resize.
Instrumenting the call sites showed that none of the 186 forceResize() calls made through getClientArea() changed the allocation that is returned afterwards.

Proposal: remove RESIZE_ON_GETCLIENTAREA, the four forceResize() calls it guards, and with it the org.eclipse.swt.resizeOnGetClientArea system property, so that Wayland and X11 behave the same.
Before merging, the real PDE API Baseline edit dialog and the JDT Pull Down wizard should be opened once on Wayland with the change.

Lenguaje dominante
Java
Estrellas
202
Forks
206
Merge medio
14 h 7 min
PR fusionados (30 d)
103

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de eclipse-platform/eclipse.platform.swt

Todos los issues de eclipse-platform/eclipse.platform.swt

Issues similares

Más issues de Java

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.