fsi --typecheck-only sometimes deadlocks on TcImports locks while registering referenced assemblies (SDK 10.0.403)

Abierto
  • ¿Algo no está bien?
#20,966 1 comentario 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 2 días

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
35/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
fsharp
Área
backend, compilers

Línea de trabajo

Start by reading the lock-invariant audit in #20804 and the deadlock reference in PR #16779, then trace RegisterAndImportReferencedAssemblies, registerDll, and the TcImports calls named in the stack traces. Try to reproduce the lock cycle with concurrent dotnet fsi --typecheck-only runs over scripts with many referenced assemblies. Done means the deadlock is fixed and the concurrent typecheck workload completes reliably.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Needs-Triage

Drafted with Claude Code (automated). Reviewed and filed on behalf of the reporter.

Summary

dotnet fsi --typecheck-only sometimes deadlocks while it registers referenced assemblies, when many fsi processes run at the same time. The hung process uses 0% CPU. Its thread-pool threads wait on Monitor.Enter inside TcImports, and other threads hold those locks and wait in Async.RunSynchronously. Each process runs alone, so the processes do not share state. The deadlock is inside one process, and load only makes it more likely.

Environment
  • .NET SDK 10.0.403, Microsoft (R) F# Interactive version 15.2.403.0 for F# 10.0
  • Windows 11 x64, 24 logical processors, 64 GB
  • Each script references about 20 project assemblies with #r (found through --lib:<folder> and #I) and #loads several other scripts, some of which declare a namespace and load .paket/load package scripts.
How it shows

A build tool runs dotnet fsi --typecheck-only <script>.fsx for about 280 scripts, 24 processes at a time. Alone, each script type-checks in about 10 to 40 seconds.

  • In each full run, 1 to 4 processes out of 100 to 300 never finish.
  • A different script hangs on each run. The hung script passes when it runs again alone.
  • A hung process used 0 s of CPU over 15 s, and it had 57 threads.
  • DOTNET_ThreadPool_ForceMinWorkerThreads=40 (64 worker threads) did not stop the hangs, so this is a lock cycle, not thread-pool starvation.

The workaround in our tool is a 3-minute timeout and one retry for each script.

Stacks of a hung process (dotnet-stack report, grouped)

Main thread:

FSharpAsync.RunSynchronously
<- CompilerImports.RequireReferences
<- FsiDynamicCompiler.ProcessDelayedReferences
<- FsiDynamicCompiler.EvalSourceFiles
<- FsiInteractionProcessor.PartiallyProcessHashDirective
<- ... <- FsiInteractionProcessor.LoadInitialFiles <- FsiEvaluationSession.Run

Thread-pool threads waiting for a lock:

4x  Monitor.Enter <- TcImports.OpenILBinaryModule <- tryGetAssemblyData
2x  Monitor.Enter <- CompilerImports.look <- fixupThunk <- PickledDataWithReferences.OptionalFixup
        <- PrepareToImportReferencedFSharpAssembly <- registerDll
1x  Monitor.Enter <- fixupThunk <- PickledDataWithReferences.OptionalFixup
        <- PrepareToImportReferencedFSharpAssembly <- registerDll
1x  Monitor.Enter <- TcImports.PrepareToImportReferencedILAssembly <- registerDll
        <- RegisterAndImportReferencedAssemblies
1x  Monitor.Enter <- TcImports.RegisterCcu <- TcImports.PrepareToImportReferencedFSharpAssembly <- registerDll
1x  Monitor.Enter <- TcImports.TryResolveAssemblyReference <- tryFile
        <- TcImports.ImplicitLoadIfAllowed <- fixupThunk <- PickledDataWithReferences.OptionalFixup

Thread-pool threads waiting for an async result while they hold their caller's locks:

13x FSharpAsync.RunSynchronously <- CompilerImports.tryFile
        <- TcImports.ImplicitLoadIfAllowed <- fixupThunk <- PickledDataWithReferences.OptionalFixup
        <- PrepareToImportReferencedFSharpAssembly <- registerDll

registerDll runs on several pool threads at once. While a thread fixes up a pickled F# assembly, ImplicitLoadIfAllowed calls tryFile, which blocks in Async.RunSynchronously on work that needs a TcImports lock that another registering thread holds.

Related
  • #20804 (audit of lock invariants now that checking is concurrent)
  • PR #16779 mentions a deadlock in RegisterAndImportReferencedAssemblies when FSI calls it.

I do not have a minimal public repro yet, because the hang is random and needs many referenced F# assemblies. I can capture a full dump of a hung process if that helps.

Lenguaje dominante
F#
Estrellas
4.3k
Forks
884
Merge medio
2 d 11 h
PR fusionados (30 d)
73

Preparar el entorno

Abrir en Codespaces

Inicia el contenedor de desarrollo del proyecto en tu navegador, con tu propia cuenta de GitHub.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de dotnet/fsharp

Todos los issues de dotnet/fsharp

Issues similares

Más issues de Backend & API Design

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.