Index created on views do not get scaffolded properly

Abierto
  • ¿Algo no está bien?
#39,616 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 2 días

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
48/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
csharp
Área
database

Línea de trabajo

Start with the reported path through RelationalIndexExtensions.GetDatabaseName() and CSharpDbContextGenerator.tt; the issue says view-mapped entities have no table name, so the generated HasIndex call gets a null name despite index metadata retaining it. Trace the existing design-time scaffolding tests for indexes on views and add coverage for the reported materialized-view case. Done means scaffolding preserves the index name and the generated context model loads successfully.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

customer-reported
Bug description

@roji @ErikEJ

This is a followup on original issue https://github.com/dotnet/efcore/issues/37345
Since that issue is closed, I couldn't reopen it.

I understand that the Oracle scenario was identified earlier in https://github.com/dotnet/efcore/issues/37345 as a separate issue. We have retested it with an Oracle EF Core 11 development build, and the null-index-name problem still reproduces.

Actual behavior and impact

Applying scaffolding using above table, materialized view, and index on the materialized view, the generated configuration still contains:

modelBuilder.Entity<MatViewDemo1>(entity =>
{
    entity.HasNoKey().ToView("MAT_VIEW_DEMO_1");

    entity.HasIndex(e => e.StringCol1, null);
});

This is not only missing metadata: accessing the generated context's Model throws:

System.ArgumentNullException: Value cannot be null. (Parameter 'name')
   at EntityTypeBuilder<TEntity>.HasIndex(..., String name)
Investigation

Boundary logging shows:

  1. The Oracle provider returns a DatabaseView containing correctly named DatabaseIndex objects and the correct columns.
  2. RelationalScaffoldingModelFactory preserves the name in the EF index metadata: index.Name is non-null.
  3. The materialized-view entity is mapped using ToView(...), with no table mapping.
  4. RelationalIndexExtensions.GetDatabaseName() returns null when GetTableName() is null.
  5. CSharpDbContextGenerator.tt uses index.GetDatabaseName() directly as the named HasIndex argument, resulting in HasIndex(..., null).

This appears to be a gap at the shared relational/design-time code-generation boundary, rather than incorrect Oracle index discovery.

Request

Could you please investigate and fix the scaffolding path so that a index supplied for a view-mapped entity produces valid configuration and preserves its name?

For the example in the https://github.com/dotnet/efcore/issues/37345, the expected configuration would be:

entity.HasIndex(e => e.StringCol1, "MAT_VIEW_DEMO_1_INDEX1");
Your code
Please find the complete scenario in https://github.com/dotnet/efcore/issues/37345
Stack traces
Verbose output
EF Core version

11.0.0

Database provider

No response

Target framework

No response

Operating system

No response

IDE

No response

Lenguaje dominante
C#
Estrellas
14.8k
Forks
3.4k
Merge medio
3 d 18 h
PR fusionados (30 d)
159

Preparar el entorno

Abrir en Codespaces

Inicia el contenedor de desarrollo del proyecto en tu navegador, con tu propia cuenta de GitHub.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de dotnet/efcore

Todos los issues de dotnet/efcore

Issues similares

Más issues de C#

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.