Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

[CleanRepo]: Images for image hyperlinks flagged as orphans

Abierto
  • ¿Algo no está bien?
#396 1 comentario 0 reacciones 1 asignado Ver en GitHub

Los mantenedores suelen responder en 1 día

@gewarren ya está trabajando en esto.

Desde el 3/12/2024.

Evaluación

Este issue todavía no se ha evaluado.

Descripción

Clean Repo seems to be flagging images incorrectly as orphaned for image hyperlinks. The image used to display for the image hyperlink is fine but in the case of an image hyperlink, the resulting image the hyperlink retrieves on a click is determined to be orphaned in the report.

Severity:
In the old aspnetdocs repo we had over 3000 image hyperlinks which Clean Repo flagged incorrectly as orphaned. However, I don't think image hyperlinks are used as much like this in other repos,

It used to be years ago, that two images were provided for screenshot image hyperlinks for our docs. One larger and one smaller and the smaller one was used as the link itself. Clicking on the screenshot or whatever the image was of, resulted in a larger version of the image being retrieved and displayed.

Recreating the issue:

  • Run the latest version of Clean Repo available today 8/20/24 in release mode.
  • Run the option for orphaned images:
    CleanRepo.exe --orphaned-images
  • Provide the details for a local cloned copy of the aspnetdocs repo.
  • Specify to not delete the images to get the report of orphaned images that incorrectly includes images referred to by image hyperlinks. (Also choosing to delete images results in incorrectly deleting images that should not be deleted.)

Results:
The list of images returned as orphaned will include the image from the image link used for the full image that is returned when the link is clicked.

Example:
In a link like the following, external-authentication-services/_static/image25.png would be determined incorrectly to be orphaned:
[![Image displaying default Facebook home page](external-authentication-services/_static/image26.png "Click to Expand the Image")](external-authentication-services/_static/image25.png)

This example image link can be found in this .md article example [here].https://raw.githubusercontent.com/dotnet/AspNetDocs/main/aspnet/web-api/overview/security/external-authentication-services.md)

It does not matter if tooltip text exists in the hyperlink or not. Same incorrect results.

Some helpful regex that could be used to find these cases:
In case you were interested here is regex I used to find examples of image hyperlinks with or without tooltip text in them:

Find image hyperlinks with tooltip text not in them:
\[!\[.*?\]\(.*?\)\]\(.*?\)

Find image hyperlinks with tooltip text in them:
\[!\[.*?".*?"\)\]\(.*?\)

Lenguaje dominante
C#
Estrellas
27
Forks
43
Merge medio
17 h 41 min
PR fusionados (30 d)
19

Preparar el entorno

Este proyecto no incluye contenedor de desarrollo, Dockerfile ni guía de contribución, así que la configuración corre por tu cuenta: empieza por su README y consulta nuestra guía para la primera contribución para los pasos generales.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de dotnet/docs-tools

Todos los issues de dotnet/docs-tools

Issues similares

Más issues de C#

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.