Should not assume TLS certificate chain is provided in order

Abierto
#1,086 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
45/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Estancado
Stack tecnológico
javascript

Línea de trabajo

Start in lib/x509.js at the referenced lines 3033-3039 and 3059-3061, and trace how the certificate chain is processed. Compare that behavior with the TLS 1.2 and TLS 1.3 requirements linked in the issue. Done means Forge handles commonly misordered certificate chains without assuming each certificate directly follows the one it certifies.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

The TLS 1.2 specification required the certificate chain to be in order:

The sender's certificate MUST come first in the list. Each following certificate MUST directly certify the one preceding it.

However, in practice, servers are commonly misconfigured to violate this requirement, and so TLS 1.3 relaxed it from MUST to SHOULD:

The sender's certificate MUST come in the first CertificateEntry in the list. Each following certificate SHOULD directly certify the one immediately preceding it.

For compatibility, Forge should not assume the chain is provided in order. It currently assumes this here:

https://github.com/digitalbazaar/forge/blob/2bb97afb5058285ef09bcf1d04d6bd6b87cffd58/lib/x509.js#L3033-L3039

https://github.com/digitalbazaar/forge/blob/2bb97afb5058285ef09bcf1d04d6bd6b87cffd58/lib/x509.js#L3059-L3061

Lenguaje dominante
JavaScript
Estrellas
5.4k
Forks
875
Merge medio
3 min
PR fusionados (30 d)
6

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de digitalbazaar/forge

Todos los issues de digitalbazaar/forge

Issues similares

Más issues de JavaScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.