python: signature verification can never succeed for Python 3.14+

Abierto
#1,764 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
52/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
shell
Área
security, tooling

Línea de trabajo

Start in src/python/install.sh around lines 532-591, where the cosign and signature downloads run. Reproduce the curl exit code 2 from -f combined with --fail-with-body, then check the .sigstore URL that python.org serves for 3.14+. Done means the downloads succeed, cosign verify-blob checks the bundle against the signer identity python.org lists, and a failed check stops the build or logs a real error.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Summary

In the python feature (1.8.0, and src/python/install.sh on main), the cosign check for Python 3.14+ always fails, so these versions are always built from source without signature verification. The build continues and logs that this is expected for newly released versions, but it happens for every version.

Causes

  1. Invalid curl flags. The cosign and signature downloads (lines 532, 544, 585, 591) pass both -f and --fail-with-body, which curl rejects with exit code 2. Most of these calls send stderr to /dev/null, and none of them surfaces the real error, so it looks like a failed download.

    curl -L -f --fail-with-body https://www.python.org/ftp/python/3.14.10/Python-3.14.10.tgz.crt -o /dev/null
    # curl: option --fail-with-body: is badly used here
    # exit code 2
    

    Reproduced with curl 8.14.1 (in a dev container built from mcr.microsoft.com/devcontainers/base:debian) and curl 8.7.1 (macOS). With --fail-with-body alone, the same request exits 0.

  2. Wrong certificate URL. Lines 580-581 look for .sig and .pem. For 3.14.10, python.org returns 200 for .sig, .crt and .sigstore, and 404 for .pem. Fixing the curl flags alone would still fail at this step.

  3. Any signer is accepted. The cosign verify-blob call uses --certificate-identity-regexp=".*" and --certificate-oidc-issuer-regexp=".*". Even a passing check wouldn't show that the Python release manager signed the file.

  4. The build continues after a failed check. If verification fails, the script logs a warning and builds the tarball anyway, and there is no checksum check. The warning says this is "expected for newly released versions where cosign signatures are not yet available", which hides the failure.

Impact

Every Python 3.14+ build from source through this feature skips signature verification. The tarball is still downloaded over HTTPS, so this doesn't create an attack by itself, but the protection that replaced PGP for 3.14+ isn't working.

Suggested fix

  1. Remove -f from the affected curl calls.

  2. Verify with the .sigstore bundle and the signer identity that python.org lists for each release series. This command returned Verified OK for 3.14.10 with cosign 3.1.4, and failed when given a different identity:

    cosign verify-blob \
      --bundle Python-3.14.10.tgz.sigstore \
      --certificate-identity [email protected] \
      --certificate-oidc-issuer https://github.com/login/oauth \
      Python-3.14.10.tgz
    
  3. Consider failing the build when verification fails, or at least changing the warning so it doesn't describe a failure as expected.

Lenguaje dominante
Shell
Estrellas
1.6k
Forks
628
Merge medio
1 d 19 h
PR fusionados (30 d)
5

Preparar el entorno

Abrir en Codespaces

Inicia el contenedor de desarrollo del proyecto en tu navegador, con tu propia cuenta de GitHub.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de devcontainers/features

Todos los issues de devcontainers/features

Issues similares

Más issues de Shell/Bash

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.