Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

install.sh wrapper relative link not resolved correctly

Abierto
#1,232 0 comentarios 0 reacciones 1 asignado Ver en GitHub

@V-Subhankar-infy ya está trabajando en esto.

Desde el 11/6/2026.

Evaluación

Este issue todavía no se ha evaluado.

Descripción

I'm trying to create a generic install method for a dotfile/software install library I maintain. I want to install a link to the binary in ~/.local/bin/ and keep the devcontainers install under ~/.local/lib/devcontainers/. The install takes care of this via the --prefix ~/.local argument.

The problem is that when I create a relative link called devcontainer from ~/.local/bin to ~/.local/lib/devcontainers/bin/devcontainer and then invoke the devcontainer executable, the generated bin file resolves the link as a relative link, rather than absolute.

Example install method:

INSTALL_DIR=$HOME/.local
curl -sSLO https://raw.githubusercontent.com/devcontainers/cli/main/scripts/install.sh
chmod +x install.sh
./install.sh --prefix "${INSTALL_DIR}"/lib/devcontainers
cd "${INSTALL_DIR}"/bin
ln -s ../lib/devcontainers/bin/devcontainer devcontainer

Example running devcontainer which is already in the PATH of ~/.local/bin/

$devcontainer
/home/vasdee/.local/bin/devcontainer: line 18: cd: ../lib/devcontainers/bin: No such file or directory

In ~/.local/bin/devcontainer i believe if the follow link logic preferred the full path option of readlink, over the relative (which is the opposite of how it is now) then the issue would be solved....at least for me

# Resolve the installation directory
# Handle both direct execution and symlinked scenarios
if [ -L "$0" ]; then
    # Follow symlink current logic 
    SCRIPT_PATH="$(readlink "$0" 2>/dev/null || readlink -f "$0" 2>/dev/null || echo "$0")"
    # Follow symlink potential fix by preferring the abs path over relative
    # SCRIPT_PATH="$(readlink -f "$0" 2>/dev/null || readlink "$0" 2>/dev/null || echo "$0")"
else
    SCRIPT_PATH="$0"
fi

I am happy to contribute a PR, but am not sure of the history behind this choice and what impact the change might have. I'm looking for guidance in that respect.

Lenguaje dominante
TypeScript
Estrellas
3k
Forks
461
Merge medio
18 min
PR fusionados (30 d)
5

Guía de contribución

Abrir la guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de devcontainers/cli

Todos los issues de devcontainers/cli

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.