Store and Resolve Previous Commit SHA for Synchronize Jobs

Abierto
#180 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
55/100
Tipo de issue
Nueva funcionalidad
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
node.js, typescript

Línea de trabajo

Start with prepare.ts and trace how synchronize jobs are created, then inspect the job schema and database code in packages/schema and packages/db. Check how job history identifies the most recently completed job for the same PR and how superseded jobs are represented. Done means the new field is persisted, the three listed cases are covered, and the required typecheck, test, and lint commands pass.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

enhancement good first issue

Goal

Store and resolve previousCommitSha for synchronize jobs so the incremental review knows which commit range to diff.

Background

To review only the files changed by the newest push, the review needs the previously reviewed head commit. The natural source is the most recently completed job for the same PR: its head SHA becomes the base for the incremental diff.

This sub-issue is part of the parent issue: incremental reviews on synchronize events.

What to Build

  • In prepare.ts (or the job preparation path), when a new job is created for a synchronize event, resolve previousCommitSha from the most recently completed job on the same PR
  • Persist previousCommitSha on the job record (schema/DB change in packages/db and packages/schema)
  • Handle the superseded-job case: if the previous job was superseded before completing, there is no valid previous SHA, so leave it unset and let the review fall back to the full PR diff
  • Keep the resolution logic runtime-agnostic so it works in both Cloudflare Workers and Node/Docker

Done When

  • New synchronize jobs carry previousCommitSha when a prior completed job exists for the same PR
  • Superseded or missing prior jobs leave previousCommitSha unset (no incorrect fallback to an older SHA)
  • Schema/DB migration works in both runtimes
  • Tests cover first-push, completed-prior-job, and superseded-prior-job cases
  • npm run typecheck, npm test, and npm run lint all pass
Lenguaje dominante
TypeScript
Estrellas
125
Forks
23
Merge medio
2 d 13 h
PR fusionados (30 d)
12

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de devarshishimpi/codra

Todos los issues de devarshishimpi/codra

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.