Support OpenAI Reasoning Models in the Model Adapter

Abierto
#171 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
48/100
Tipo de issue
Nueva funcionalidad
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
typescript

Línea de trabajo

Start with packages/models/src/providers/openai.ts around lines 138–160 and trace how the adapter builds request parameters and reads model sampling profiles. Check how existing tests construct standard model requests, then add coverage for reasoning and standard models as the work breakdown specifies. Done means the request fields match each model family’s requirements and the listed typecheck, test, and lint commands pass.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

bug good first issue

Summary

Codra's OpenAI adapter in packages/models/src/providers/openai.ts unconditionally sends temperature and max_tokens to every OpenAI model. Modern OpenAI reasoning models including the o-series (o1, o3, o3-mini, o4-mini) and newer GPT-5/GPT-6 family models in reasoning mode reject these parameters and return HTTP 400 Bad Request, making it impossible to route Codra reviews to any OpenAI reasoning model.

This is the parent issue. See sub-issues for the specific implementation tasks.

Work Breakdown

  • Sub-issue: Add reasoning model detection helper and conditional request body (covers max_completion_tokens and role: "developer")
  • Sub-issue: Add reasoning_effort support via model sampling profile
  • Sub-issue: Tests for reasoning and standard model request construction

Affected File

packages/models/src/providers/openai.ts lines 138-160:

const bodyPayload: Record<string, unknown> = {
  model,
  messages: [
    { role: "system", content: prompts.system },
    { role: "user", content: prompts.user },
  ],
  temperature,                        // rejected by o1, o3, o3-mini, o4-mini
  max_tokens: effectiveCeiling,       // must be max_completion_tokens for reasoning models
  response_format: { type: "json_object" },
};

OpenAI Reasoning Model API Requirements

Model family temperature max_tokens max_completion_tokens reasoning_effort
gpt-4o, gpt-4o-mini accepted accepted - -
gpt-5, gpt-5-mini accepted accepted - -
o1, o1-mini rejected rejected required optional
o3, o3-mini rejected rejected required supported
o4-mini rejected rejected required supported
gpt-6 (reasoning mode) rejected rejected required supported

Reasoning models generate internal chain-of-thought tokens before producing output. max_completion_tokens controls the ceiling over both reasoning and output tokens combined.

Done When

  • o1, o3, o3-mini, o4-mini models receive max_completion_tokens instead of max_tokens
  • temperature is omitted for reasoning models
  • role: "developer" replaces role: "system" for reasoning model system prompts
  • reasoning_effort is populated from the model sampling profile when available
  • Detection logic is forward-compatible (prefix-based, not a hardcoded list of model names)
  • Standard models (gpt-4o, gpt-4o-mini, gpt-5, custom base URLs) continue working unchanged
  • Tests cover reasoning model request construction and standard model construction
  • npm run typecheck, npm test, and npm run lint all pass
Lenguaje dominante
TypeScript
Estrellas
125
Forks
23
Merge medio
2 d 13 h
PR fusionados (30 d)
12

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de devarshishimpi/codra

Todos los issues de devarshishimpi/codra

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.