Support OpenAI Reasoning Models in the Model Adapter
Los mantenedores suelen responder en 1 día
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Aptitud para principiantes
- 48/100
- Tipo de issue
- Nueva funcionalidad
- Claridad
- Bastante claro
- Estado de actividad
- Activo
- Stack tecnológico
- typescript
- Área
- ai, backend-api-design
Línea de trabajo
Start with packages/models/src/providers/openai.ts around lines 138–160 and trace how the adapter builds request parameters and reads model sampling profiles. Check how existing tests construct standard model requests, then add coverage for reasoning and standard models as the work breakdown specifies. Done means the request fields match each model family’s requirements and the listed typecheck, test, and lint commands pass.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Summary
Codra's OpenAI adapter in packages/models/src/providers/openai.ts unconditionally sends temperature and max_tokens to every OpenAI model. Modern OpenAI reasoning models including the o-series (o1, o3, o3-mini, o4-mini) and newer GPT-5/GPT-6 family models in reasoning mode reject these parameters and return HTTP 400 Bad Request, making it impossible to route Codra reviews to any OpenAI reasoning model.
This is the parent issue. See sub-issues for the specific implementation tasks.
Work Breakdown
- Sub-issue: Add reasoning model detection helper and conditional request body (covers
max_completion_tokensandrole: "developer") - Sub-issue: Add
reasoning_effortsupport via model sampling profile - Sub-issue: Tests for reasoning and standard model request construction
Affected File
packages/models/src/providers/openai.ts lines 138-160:
const bodyPayload: Record<string, unknown> = {
model,
messages: [
{ role: "system", content: prompts.system },
{ role: "user", content: prompts.user },
],
temperature, // rejected by o1, o3, o3-mini, o4-mini
max_tokens: effectiveCeiling, // must be max_completion_tokens for reasoning models
response_format: { type: "json_object" },
};
OpenAI Reasoning Model API Requirements
| Model family | temperature |
max_tokens |
max_completion_tokens |
reasoning_effort |
|---|---|---|---|---|
gpt-4o, gpt-4o-mini |
accepted | accepted | - | - |
gpt-5, gpt-5-mini |
accepted | accepted | - | - |
o1, o1-mini |
rejected | rejected | required | optional |
o3, o3-mini |
rejected | rejected | required | supported |
o4-mini |
rejected | rejected | required | supported |
gpt-6 (reasoning mode) |
rejected | rejected | required | supported |
Reasoning models generate internal chain-of-thought tokens before producing output. max_completion_tokens controls the ceiling over both reasoning and output tokens combined.
Done When
-
o1,o3,o3-mini,o4-minimodels receivemax_completion_tokensinstead ofmax_tokens -
temperatureis omitted for reasoning models -
role: "developer"replacesrole: "system"for reasoning model system prompts -
reasoning_effortis populated from the model sampling profile when available - Detection logic is forward-compatible (prefix-based, not a hardcoded list of model names)
- Standard models (
gpt-4o,gpt-4o-mini,gpt-5, custom base URLs) continue working unchanged - Tests cover reasoning model request construction and standard model construction
-
npm run typecheck,npm test, andnpm run lintall pass
- Lenguaje dominante
- TypeScript
- Estrellas
- 125
- Forks
- 23
- Merge medio
- 2 d 13 h
- PR fusionados (30 d)
- 12
Preparar el entorno
- Incluye un Dockerfile o un archivo de Docker Compose
- Tiene una plantilla de pull request
- Leer la guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de devarshishimpi/codra
-
bug good first issue
Dificultad 2/5 1-3 horas Aptitud para principiantes 84/100
devarshishimpi/codra#178 ·
Los mantenedores suelen responder en 1 día
-
bug good first issue
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
devarshishimpi/codra#176 ·
Los mantenedores suelen responder en 1 día
-
enhancement good first issue
Dificultad 4/5 3-5 días Aptitud para principiantes 48/100
devarshishimpi/codra#186 ·
Los mantenedores suelen responder en 1 día
-
enhancement good first issue
Dificultad 4/5 3-5 días Aptitud para principiantes 55/100
devarshishimpi/codra#185 ·
Los mantenedores suelen responder en 1 día
-
enhancement good first issue
Dificultad 4/5 3-5 días Aptitud para principiantes 58/100
devarshishimpi/codra#184 ·
Los mantenedores suelen responder en 1 día
Todos los issues de devarshishimpi/codra
Issues similares
-
Dificultad 1/5 1-3 horas Aptitud para principiantes 83/100
gofish-graphics/gofish-graphics#1384 ·
Los mantenedores suelen responder en 1 día
-
adapter bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 83/100
Olanetsoft/agent-lookout#353 ·
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 68/100
vicharanashala/vibe#1542 ·
Los mantenedores suelen responder en 1 día
-
bug chore P2 size:XS
Dificultad 2/5 1-3 horas Aptitud para principiantes 77/100
josephfung/curia#2666 ·
Los mantenedores suelen responder en 1 día
-
area: batch
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
inabagumi/shinju-date#7294 ·
Los mantenedores suelen responder en 1 día